Thanks @aluzzardi LGTM

LGTM

Thanks @aluzzardi, do we need to have this cherry-picked back to master, or will you open a separate PR?

@mavenugo based on the description of moby/swarmkit#1693, and it being linked to #25016, I think this has user-facing changes? If so, this may need changes in the documentation, and changelog.

Also, does this fix #25016 ?

Thanks Sebastiaan - I think we'll open a PR to sync SwarmKit master into
docker master (everything - not just the cherry picks).

We basically have a 1.13 branch in SwarmKit in which we cherry pick stuff
from SwarmKit master and revendor the 1.13 docker branch from it.

Then docker master in which we just revendor SwarmKit master.

Makes sense?

On Wed, Nov 16, 2016 at 1:07 AM Sebastiaan van Stijn <
[email protected]> wrote:

@mavenugo https://github.com/mavenugo based on the description of
moby/swarmkit#1693 moby/swarmkit#1693, and
it being linked to #25016 #25016,
I think this has user-facing changes? If so, this may need changes in the
documentation, and changelog.

Also, does this fix #25016 #25016
?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#28463 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAK9Lxv3ifoWQYEktul11vPVgnRWuuq-ks5q-se3gaJpZM4KzS9z
.

@thaJeztah This doesn't fix #25016. It merely an add-on change to the recently introduced --port functionality with PublihMode=host. The docs needs an update for the new --port changes and we can add this behaviour along with it.