Use Container.Config.Shell instead of hardcoded…#28438
Merged
vieux merged 1 commit intomoby:masterfrom Nov 19, 2016
Merged
Conversation
vdemeester
added
process/cherry-pick
status/2-code-review
and removed
status/0-triage
labels
vdemeester
force-pushed
the
use-container-shell-instead-of-hardcoded
branch
from
6503e8b to
f61178a
Compare
vdemeester
commented
Nov 15, 2016
Member
Author
There was a problem hiding this comment.
This is duplicated with builder/dockerfile/builder_unix.go (and its windows counter-part), we might want to extract that 👼
cpuguy83
reviewed
Nov 15, 2016
Member
There was a problem hiding this comment.
Don't much care for this random getShell function in the daemon package.
Maybe Shell() on Config would be better.
Also, what if Shell is supposed to be empty?
Member
Author
There was a problem hiding this comment.
Hum I like the idea of Shell() method on Config 👼
Right now Shell is only used while building to set the right Entrypoint — it's not used during runtime. If Shell is empty, it means it has not be set and thus we should use the default behavior (i.e. either Container.Entypoint or the current values).
vdemeester
force-pushed
the
use-container-shell-instead-of-hardcoded
branch
3 times, most recently
from
54901e9 to
b9ac5b2
Compare
… for healthcheck. It make the code a little cleaner and more future/usage proof. Signed-off-by: Vincent Demeester <[email protected]>
vdemeester
force-pushed
the
use-container-shell-instead-of-hardcoded
branch
from
b9ac5b2 to
5f81cf1
Compare
Contributor
|
LGTM |
1 similar comment
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… for healthcheck. It make the code a little cleaner and more future/usage proof. Hopefully it's all green 👼
/cc @justincormack @talex5 @thaJeztah @cpuguy83
🐸
Signed-off-by: Vincent Demeester [email protected]