Skip to content

Generate more types from the swagger spec#28409

Merged
LK4D4 merged 6 commits intomoby:masterfrom
dnephin:swagger-gen-more
Jan 26, 2017
Merged

Generate more types from the swagger spec#28409
LK4D4 merged 6 commits intomoby:masterfrom
dnephin:swagger-gen-more

Conversation

@dnephin
Copy link
Member

@dnephin dnephin commented Nov 14, 2016

See #27919

@cpuguy83
Copy link
Member

cpuguy83 commented Nov 14, 2016 

20:18:19 # github.com/docker/docker/integration-cli
20:18:19 .\docker_api_images_test.go:112: undefined: "github.com/docker/docker/api/types".ImageHistory
20:18:19 FAIL   github.com/docker/docker/integration-cli [build failed]
20:18:20

vieux
vieux reviewed Nov 15, 2016
View reviewed changes
api/types/container/container_top.go Outdated
Copy link
Contributor

@vieux vieux Nov 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this top o k body seems wrong (reminds me ok g ID)

Even the d name feels weird no ? OK in the variable.

Copy link
Member Author

@dnephin dnephin Nov 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment gets a bit messed up because of how swagger generates it. I can look at fixing the comment generation.

Is that what you mean?

Copy link
Contributor

@vieux vieux Nov 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes for the comment, it can come later.
I also meant: the method name seem strange to me. but it's fine.

@vieux
Copy link
Contributor

vieux commented Nov 19, 2016

needs rebase, but LGTM

@dnephin
Copy link
Member Author

dnephin commented Nov 21, 2016

Rebased. I sorted the list so that it should conflict less often.

@dnephin dnephin closed this Nov 21, 2016
@dnephin dnephin reopened this Nov 21, 2016
@dnephin dnephin force-pushed the swagger-gen-more branch 4 times, most recently from 0272559 to 2672555 Compare November 28, 2016 19:31
@dnephin
Copy link
Member Author

dnephin commented Dec 27, 2016

rebased

@dnephin dnephin force-pushed the swagger-gen-more branch 2 times, most recently from 4c1acae to 17f9f5a Compare January 3, 2017 16:47
@LK4D4
Copy link
Contributor

LK4D4 commented Jan 26, 2017

Still not requires rebase after 23 days. That's a good sign.

LK4D4
LK4D4 approved these changes Jan 26, 2017
View reviewed changes
Copy link
Contributor

@LK4D4 LK4D4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LK4D4 LK4D4 merged commit a69c412 into moby:master Jan 26, 2017
@GordonTheTurtle GordonTheTurtle added this to the 1.14.0 milestone Jan 26, 2017
@dnephin dnephin deleted the swagger-gen-more branch January 26, 2017 18:36
@aboch aboch mentioned this pull request Jan 26, 2017
Merged
@thaJeztah thaJeztah modified the milestones: 1.13.2, 1.14.0 Feb 17, 2017
@thaJeztah thaJeztah modified the milestones: 1.14.0, 1.13.2 Feb 17, 2017
@thaJeztah thaJeztah mentioned this pull request Feb 17, 2017
Merged
dnephin pushed a commit to dnephin/docker that referenced this pull request Apr 17, 2017
@LK4D4
Merge pull request moby#28409 from dnephin/swagger-gen-more
540ba12 
Generate more types from the swagger spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@vieux vieux vieux left review comments

@LK4D4 LK4D4 LK4D4 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status/2-code-review

Projects

None yet

Milestone

17.04.0

Development

Successfully merging this pull request may close these issues.

6 participants

@dnephin @cpuguy83 @vieux @LK4D4 @thaJeztah @GordonTheTurtle