only check secrets for service create if requested#28306
Merged
vdemeester merged 1 commit intomoby:masterfrom Nov 11, 2016
Merged
only check secrets for service create if requested#28306vdemeester merged 1 commit intomoby:masterfrom
vdemeester merged 1 commit intomoby:masterfrom
Conversation
Signed-off-by: Evan Hazlett <[email protected]>
Member
|
LGTM |
2 similar comments
Contributor
|
LGTM |
|
LGTM |
Member
|
/cc @vieux for cherry-picking |
dnephin
pushed a commit
to dnephin/docker
that referenced
this pull request
Apr 17, 2017
only check secrets for service create if requested
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where secrets were trying to be parsed when none specified on service create.
/cc @aaronlehmann