Skip to content

[doc] Update docs/deprecated.md for 1.13#28293

Merged
vdemeester merged 1 commit intomoby:masterfrom
AkihiroSuda:update-deprecate-md
Nov 11, 2016
Merged

[doc] Update docs/deprecated.md for 1.13#28293
vdemeester merged 1 commit intomoby:masterfrom
AkihiroSuda:update-deprecate-md

Conversation

@AkihiroSuda
Copy link
Copy Markdown
Member

CHANGELOG is tracked in #28275

cc @vieux

Signed-off-by: Akihiro Suda [email protected]

@vieux
Copy link
Copy Markdown
Contributor

vieux commented Nov 11, 2016

@AkihiroSuda already needs a rebase

Comment thread docs/deprecated.md
Duplicate keys with conflicting values have been deprecated. A warning is displayed
in the output, and an error will be returned in the future.

### `MAINTAINER` in Dockerfile
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this section is just moved from the tail of the original file

Comment thread docs/deprecated.md

`MAINTAINER` was an early very limited form of `LABEL` which should be used instead.

### API calls without a version
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this section is just moved from the tail of the original file

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about the rule about sections. Maybe we should explicitly add a H2 section like ## Deprecated In Release: v1.13.0

Comment thread docs/deprecated.md
future Engine versions. Instead of just requesting, for example, the URL
`/containers/json`, you must now request `/v1.25/containers/json`.

### Backing filesystem without `d_type` support for overlay/overlay2
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this section is new in this PR

@AkihiroSuda
Copy link
Copy Markdown
Member Author

sorry, rebased 😅 @vieux

@vieux
Copy link
Copy Markdown
Contributor

vieux commented Nov 11, 2016

ping @thaJeztah

@vdemeester vdemeester added this to the 1.13.0 milestone Nov 11, 2016
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Copy Markdown
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants