/cc @aaronlehmann @stevvooe

LGTM

@dmcgowan tests are failing

Looks like trust failures are related to distribution/distribution#2044 in distribution. Going to update the trust build code to ensure the output is not changing due to this change.

Added a commit which resolves the issues with the distribution vendor update. The change to WithDigest required an additional method to remove tag before calling to preserve existing behavior. We have already discussed this on the distribution issue as the correct way to use WithDigest rather than assuming it will remove the tag.

Tested docker pull and docker service create with name:tag@digest syntax and didn't find any problems.

LGTM

However it's very possible that the only reason why these things work correctly is that github.com/docker/docker/reference drops the tag in ParseNamed:

        if canonical, isCanonical := named.(distreference.Canonical); isCanonical {
                return WithDigest(r, canonical.Digest())
        }
        if tagged, isTagged := named.(distreference.NamedTagged); isTagged {
                return WithTag(r, tagged.Tag())
        }

We should probably fix ParseNamed to be consistent with the upstream changes. But that may cause more issues.

@aaronlehmann I saw that in ParseNamed figuring out where to update. I recall that was done intentionally to prevent the creation of a tagged and digested reference, but there is no comment explaining it and I can't think of an error it would cause. Seems to me like more of a problem to have it strip data such that ParsedNamed(s).String() != s. We can address this upon deprecation of the docker/docker/reference fork.

@dmcgowan: It turns out this is an issue for service create. Creating a service with the image reference busybox:latest@sha256:29f5d56d12684887bdfa50dcd29fc31eea4aaf4ad3bec43daf19026a7ce69912 strips out the tag in service ls, whereas specifying busybox:latest keeps the tag and adds a digest as well. I suggested using ParseNamed from github.com/docker/distribution/reference to work around this.

cc @nishanttotla

LGTM

let's wait for #27917 before merging

Adding some utility functions so that we can move to using ParseNamed from docker/distribution/reference here: distribution/distribution#2062