update experimental/README.md by AkihiroSuda · Pull Request #28160 · moby/moby

AkihiroSuda · 2016-11-08T10:35:29Z

Signed-off-by: Akihiro Suda [email protected]

AkihiroSuda · 2016-11-08T10:36:06Z

thaJeztah · 2016-11-08T12:16:26Z

experimental/README.md

Perhaps we should explain how to set it through the daemon.json file instead? That way, we don't have to explain how to create a drop-in file for systemd, and how to daemon-reload etc

Probably a good thing to have both.

I'd make it more generic by stating that the service file for docker needs to be updated.

Not everyone has moved to systemd yet (present company included :))

mlaventure · 2016-11-08T16:22:15Z

cc @andrewhsu

andrewhsu · 2016-11-09T01:57:10Z

@AkihiroSuda for the upcoming release, we're going to keep the existing endpoints up for installing experimental so we need the instructions. We're also going to need the DOCKER_EXPERIMENTAL environment variable to build a separate experimental RPM with experimental flag enabled by default. So, I'd say don't change the build-rpm file.

If you want to keep the section you add to the README.md and not delete the Install Docker experimental section, that would be valuable.

AkihiroSuda · 2016-11-09T03:02:04Z

@andrewhsu

OK, entirely changed PR.

Now it enables experimental features by default if the binary is built with DOCKER_EXPERIMENTAL.

experimental.docker.com will provide the binary with experimental features enabled by default. I believe the admin for experimental.docker.com has no additional task for that.
build-rpm is not changed, and can provide the binary with experimental features enabled by default if DOCKER_EXPERIMENTAL is set
experimental/README.md mentions both experimental-by-default binary and regular binary.

AkihiroSuda · 2016-11-09T03:22:22Z

cc @mlaventure @icecrime

andrewhsu · 2016-11-09T06:32:59Z

@AkihiroSuda what you had for just the README.md looks like it is worthwhile for review and can be treated independently. If you just have that in a PR it looks like it can be merged in faster.

As for enabling experimental by default upon install of a docker-engine package...the code should already be in master branch for reading the daemon.json config file and checking for experimental flag. So, no need to create another build flag experimentalbydefault.

The DOCKER_EXPERIMENTAL=1 value is passed in to docker-engine.spec via build-rpm. The docker-engine.spec file will need an if-then stmt based on this value to add an entry to daemon.json to build the package with experimental enabled by default upon install. @mlaventure had identified this in #27788.

AkihiroSuda · 2016-11-09T06:57:30Z

@andrewhsu OK, updated PR to only contain experimental/README.md

AkihiroSuda · 2016-11-09T06:59:35Z

experimental/README.md

I removed this line because make binary doesn't produce daemon.json with the experimental flag.

AkihiroSuda · 2016-11-09T07:01:19Z

experimental/README.md

I removed this line because IIUC tgz is unlikely to contain daemon.json with the experimental flag.
Maybe we should mention RPM (and DEB, right?) here later.

mlaventure · 2016-11-09T16:00:28Z

experimental/README.md

The experimental package is built on the same schedule as the regular Docker binary now, this part also needs to be updated

Perhaps wording along the lines of:

Experimental features are now included in the standard docker binaries as of version 1.13.0.

Also tweaking of wording s/From one day to the next/From one release to the next/

mlaventure · 2016-11-11T16:46:36Z

experimental/README.md

+If you install Docker from `experimental.docker.com`, the experimental features
+are enabled by default.
+The experimental package available at `experimental.docker.com` is almost
+identical to the standard Docker package, but it contains `daemon.json` for


@andrewhsu is that going to be the case or are we going to use the cli flag?

PTAL @andrewhsu

#28194 (comment)

There will not be a release of experimental binaries for the 1.13.0 GA, so no need to create work for making sure the binaries are released.

Should we just remove this subsection?
PTAL @andrewhsu

LK4D4 · 2016-11-30T18:53:38Z

ping @andrewhsu

AkihiroSuda · 2016-12-15T15:32:04Z

#29389

There will not be a release of experimental binaries for the 1.13.0 GA

Updated PR according to this.

thaJeztah · 2016-12-15T16:21:31Z

experimental/README.md

looks like this is still using 8 spaces for indentation (which is no longer needed because the numbered list is gone).
while updating, can you use "fences" for this block, and a JSON code-hint? i.e.

```json { "experimental":true } ```

thaJeztah · 2016-12-15T16:21:50Z

experimental/README.md

same here, but with a bash type hint

Signed-off-by: Akihiro Suda <[email protected]>

AkihiroSuda · 2016-12-16T04:03:27Z

done @thaJeztah

thaJeztah

LGTM, thanks!

vdemeester

LGTM 🐸

GordonTheTurtle added the status/0-triage label Nov 8, 2016

AkihiroSuda mentioned this pull request Nov 8, 2016

Fix typos and url in experimental #28154

Closed

vdemeester added status/2-code-review and removed status/0-triage labels Nov 8, 2016

thaJeztah reviewed Nov 8, 2016

View reviewed changes

AkihiroSuda force-pushed the update-experimental-md branch from d038cfe to d2db354 Compare November 8, 2016 16:35

thaJeztah added this to the 1.13.0 milestone Nov 8, 2016

vieux assigned andrewhsu Nov 8, 2016

AkihiroSuda force-pushed the update-experimental-md branch from d2db354 to 0d24211 Compare November 9, 2016 02:53

AkihiroSuda changed the title ~~Update files related to EXPERIMENTAL~~ Enable exp features by default if built with DOCKER_EXPERIMENTAL Nov 9, 2016

AkihiroSuda added status/1-design-review and removed status/2-code-review labels Nov 9, 2016

AkihiroSuda mentioned this pull request Nov 9, 2016

remaining issues for experimental build changes #28194

Closed

4 tasks

AkihiroSuda force-pushed the update-experimental-md branch from 0d24211 to eef9534 Compare November 9, 2016 06:55

AkihiroSuda changed the title ~~Enable exp features by default if built with DOCKER_EXPERIMENTAL~~ update experimental/README.md Nov 9, 2016

AkihiroSuda added status/3-docs-review and removed status/1-design-review labels Nov 9, 2016

AkihiroSuda commented Nov 9, 2016

View reviewed changes

mlaventure suggested changes Nov 9, 2016

View reviewed changes

AkihiroSuda force-pushed the update-experimental-md branch from eef9534 to 8a02480 Compare November 11, 2016 09:44

mlaventure reviewed Nov 11, 2016

View reviewed changes

vieux added the process/docs-cherry-pick label Nov 12, 2016

thaJeztah added process/cherry-pick and removed process/docs-cherry-pick labels Dec 13, 2016

thaJeztah mentioned this pull request Dec 14, 2016

Make experimental a runtime flag #27223

Merged

3 tasks

AkihiroSuda force-pushed the update-experimental-md branch from 8a02480 to 3dce3c3 Compare December 15, 2016 15:32

thaJeztah reviewed Dec 15, 2016

View reviewed changes

experimental/README.md Outdated

Copy link

Member

thaJeztah Dec 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, but with a bash type hint

update experimental/README.md

eb11a10

Signed-off-by: Akihiro Suda <[email protected]>

AkihiroSuda force-pushed the update-experimental-md branch from 3dce3c3 to eb11a10 Compare December 16, 2016 04:03

thaJeztah approved these changes Dec 16, 2016

View reviewed changes

vdemeester approved these changes Dec 16, 2016

View reviewed changes

thaJeztah merged commit f6ba849 into moby:master Dec 18, 2016

tiborvass mentioned this pull request Dec 19, 2016

[WIP] 1.13.0 rc5 cherrypicks #29555

Closed

tiborvass added process/cherry-picked process/cherry-pick and removed process/cherry-pick process/cherry-picked labels Dec 19, 2016

vieux added process/cherry-picked and removed process/cherry-pick labels Jan 3, 2017

vieux mentioned this pull request Jan 3, 2017

1.13.0 rc5 cherrypicks #29866

Merged

Conversation

AkihiroSuda commented Nov 8, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AkihiroSuda commented Nov 8, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mlaventure commented Nov 8, 2016

Uh oh!

andrewhsu commented Nov 9, 2016

Uh oh!

AkihiroSuda commented Nov 9, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AkihiroSuda commented Nov 9, 2016

Uh oh!

andrewhsu commented Nov 9, 2016

Uh oh!

AkihiroSuda commented Nov 9, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LK4D4 commented Nov 30, 2016

Uh oh!

AkihiroSuda commented Dec 15, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AkihiroSuda commented Dec 16, 2016

Uh oh!

thaJeztah left a comment

Choose a reason for hiding this comment

Uh oh!

vdemeester left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

AkihiroSuda commented Nov 8, 2016 •

edited

Loading

AkihiroSuda commented Nov 9, 2016 •

edited

Loading