Add support for swarm mode templating#28025
Merged
vieux merged 2 commits intomoby:masterfrom Nov 9, 2016
Merged
Conversation
Member
Author
|
@AkihiroSuda doesn't need vendoring, it's already vendored (just wasn't used so the package was cleaned) — the vendor check is green 😉 |
Member
|
oh, sorry 😅 |
vdemeester
force-pushed
the
swarm-mode-templating
branch
2 times, most recently
from
b43cacd to
09134fa
Compare
Contributor
|
Thanks for carrying this! I suspect we will run into some validation problems when passing through template syntax. It might be good to have a few tests that create services that flex these pipelines end to end. Specific areas in order of sensitivity:
|
vdemeester
force-pushed
the
swarm-mode-templating
branch
2 times, most recently
from
e7be206 to
7fd02d3
Compare
vdemeester
added
the
status/failing-ci
vdemeester
force-pushed
the
swarm-mode-templating
branch
from
7fd02d3 to
c11909f
Compare
vdemeester
added
status/needs-vendoring
and removed
status/failing-ci
vdemeester
force-pushed
the
swarm-mode-templating
branch
from
c11909f to
aac0c77
Compare
Contributor
|
moby/swarmkit#1738 was merged |
Signed-off-by: Vincent Demeester <[email protected]>
vdemeester
force-pushed
the
swarm-mode-templating
branch
from
aac0c77 to
2a61fa9
Compare
Wire templating support of swarmkit for the engine, in order to be used through services. Signed-off-by: Vincent Demeester <[email protected]>
vdemeester
force-pushed
the
swarm-mode-templating
branch
from
2a61fa9 to
6212ea6
Compare
Contributor
|
LGTM |
1 similar comment
Contributor
|
LGTM |
Member
|
@vieux @vdemeester looks like we missed this in the changelog |
Member
|
#28022 is tracking the documentation part, so removing docs/revisit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wire templating support of swarmkit for the engine, in order to be used through services 🐮 — #27995 updated swarmkit but did not wire it (and thus the package wasn't kept either).
Closes #28022
/cc @thaJeztah @stevvooe @aaronlehmann @icecrime
🐸
Signed-off-by: Vincent Demeester [email protected]