Fix case where \ at EOF made the builder ignore the command#27873
Merged
lowenna merged 1 commit intomoby:masterfrom Nov 3, 2016
Merged
Fix case where \ at EOF made the builder ignore the command#27873lowenna merged 1 commit intomoby:masterfrom
lowenna merged 1 commit intomoby:masterfrom
Conversation
Contributor
Author
|
ping @MichaelSimons - just FYI, I didn't forget about how you noticed this issue |
MHBauer
reviewed
Oct 29, 2016
Contributor
There was a problem hiding this comment.
good comment. I was wondering where true was used.
duglin
changed the title
Contributor
|
Can we have a test for this so we know what the intended behaviour is please, they are alas the main documentation of the quirks of Dockerfile parsing. |
Contributor
Author
|
@justincormack I did add a few tests, I'm not sure what you're looking for. |
Member
|
LGTM. Thanks @duglin - I've got one more bug in the builder too I'm tracking down as a result of that issue. Windows specific though. |
Contributor
|
@duglin thanks LGTM. Needs a rebase though. |
Came from looking at issue moby#27545 Signed-off-by: Doug Davis <[email protected]>
Contributor
Author
|
rebased |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Came from looking at issue #27545
In a Dockerfile with something like:
The \ at the end of the last line would cause the parser to totally ignore the last line - not good.
Signed-off-by: Doug Davis [email protected]