Skip to content

fixes #2671, add support for bind mounting individual files in to contai...#2775

Merged
creack merged 1 commit intomoby:masterfrom
daniel-garcia:2671-bindmount_files
Dec 2, 2013
Merged

fixes #2671, add support for bind mounting individual files in to contai...#2775
creack merged 1 commit intomoby:masterfrom
daniel-garcia:2671-bindmount_files

Conversation

@daniel-garcia
Copy link
Copy Markdown
Contributor

@daniel-garcia daniel-garcia commented Nov 19, 2013

...ners, rebases of #1757 #2301

@daniel-garcia daniel-garcia mentioned this pull request Nov 19, 2013
Closed
@daniel-garcia
Copy link
Copy Markdown
Contributor Author

daniel-garcia commented Nov 19, 2013

@unclejack, this is a rebase of #2682

@crosbymichael
Copy link
Copy Markdown
Contributor

crosbymichael commented Nov 22, 2013

@daniel-garcia

The tests currently fail to build with this error:

./container_test.go:1262: cannot use r (type *docker.Runtime) as type *engine.Engine in function argument
./container_test.go:1262: cannot use []string literal (type []string) as type *docker.Runtime in function argument
./container_test.go:1262: cannot use t (type *testing.T) as type []string in function argument
./container_test.go:1262: not enough arguments in call to runContainer
FAIL    github.com/dotcloud/docker/integration [build failed]

@daniel-garcia
Copy link
Copy Markdown
Contributor Author

daniel-garcia commented Nov 22, 2013

@crosbymichael, fixed unit test compilation, api of runContainer changed in test harness. Please retest.

@crosbymichael
Copy link
Copy Markdown
Contributor

crosbymichael commented Nov 28, 2013

LGTM

@crosbymichael crosbymichael mentioned this pull request Nov 29, 2013
Closed
@tianon
Copy link
Copy Markdown
Member

tianon commented Dec 2, 2013

+1 - tested this to be working swell here for normal files :)

@crosbymichael
Copy link
Copy Markdown
Contributor

crosbymichael commented Dec 2, 2013

ping @creack

@creack
Copy link
Copy Markdown
Contributor

creack commented Dec 2, 2013

LGTM

creack added a commit that referenced this pull request Dec 2, 2013
@creack
Merge pull request #2775 from daniel-garcia/2671-bindmount_files
d6cdbca 
fixes #2671, add support for bind mounting individual files in to contai...
@creack creack merged commit d6cdbca into moby:master Dec 2, 2013
@daniel-garcia daniel-garcia deleted the 2671-bindmount_files branch December 2, 2013 23:16
@tianon tianon mentioned this pull request Dec 4, 2013
Closed
@vreon vreon mentioned this pull request Dec 8, 2013
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@daniel-garcia @crosbymichael @tianon @creack