Added Logentries Driver#27471
Merged
thaJeztah merged 2 commits intomoby:masterfrom Oct 18, 2016
caarlos0:logentries
Merged
Conversation
Signed-off-by: Carlos Alexandro Becker <[email protected]>
Signed-off-by: Carlos Alexandro Becker <[email protected]>
thaJeztah
added
status/3-docs-review
impact/changelog
impact/cli
impact/documentation
and removed
status/0-triage
labels
thaJeztah
approved these changes
Oct 18, 2016
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM, thanks!
ping @vdemeester @albers @sdurrheimer if you could have a quick look at the completion scripts
Member
|
bash completion is perfect 👍 |
Member
|
Thanks @albers @sdurrheimer ! |
Contributor
Author
|
Thanks all! |
Member
|
ping @caarlos0 can you take a look at bsphere/le_go#14 regarding licensing for le_go? Thanks! |
Contributor
Author
Member
|
❤️ thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopening #22699 because I removed my fork and github lost track of it.
Also made the changes asked by @thaJeztah .
Docs were made on PR docker/docs#244