Make experimental a runtime flag by mlaventure · Pull Request #27223 · moby/moby

mlaventure · 2016-10-07T20:59:40Z

Signed-off-by: Kenfe-Mickael Laventure [email protected]

Left to do:

Update the install script to automatically set "experimental": true if fetched from https://experimental.docker.com/
~~See what solution is adopted by API/CLI version mismatch #25498 and piggy back on it to check the daemon experimental flag~~
Update documentation

Closes #26713

AkihiroSuda · 2016-10-13T09:30:22Z

integration-cli/check_test.go

nit: IMO the comment should be moved to L267

Updated, thanks.

icecrime · 2016-10-17T21:51:19Z

See what solution is adopted by #25498 and piggy back on it to check the daemon experimental flag

~~I think it's perfectly fine to rely on /info in the meantime (we're just talking about optimizations here).~~ Nevermind, Swarm-mode makes this potentially slow.

Otherwise design LGTM 👍

icecrime · 2016-10-19T16:45:59Z

See what solution is adopted by #25498 and piggy back on it to check the daemon experimental flag

This is a requirement, but it won't change much about this PR, so I'm moving it to code review so we can try and get it in for 1.13.0.

justincormack · 2016-10-20T14:21:08Z

This seems to be working as expected, code looks fine.

LGTM

LK4D4 · 2016-10-20T15:07:03Z

LGTM
@mlaventure but need rebase

tianon · 2016-10-20T18:55:24Z

hack/make/build-rpm

Shouldn't this block just be removed completely, as in build-deb?

Should I remove --define '_experimental ${DOCKER_EXPERIMENTAL:-0}' too ?

thaJeztah · 2016-10-20T18:57:16Z

We should have a CI check or label to prevent future PR's from adding an experimental build-flag

/cc @ehazlett @mlaventure

tianon · 2016-10-20T18:57:29Z

integration-cli/docker_experimental_network_test.go

Were we just never running tests on windows with experimental enabled previously?

Correct, all the test have DaemonIsLinux as a prerequisite

tianon · 2016-10-20T19:00:12Z

hack/make/.integration-daemon-start

Aren't the experimental features tested regardless of whether this is set on our integration daemon, or does this mean we'll still need to run the full test suite twice (once without and once with this set)?

Without it the experimental endpoint are not "exposed" to the clients.

However, if there''s code elsewhere that is supposed to be experimental and isn't guard by the proper check, testing both with and without the flag should help catch it.

vdemeester · 2016-10-24T21:21:49Z

@thaJeztah @mlaventure should we move this to docs-review or should we do that in a follow up PR?

vieux

LGTM

ehazlett · 2016-10-24T22:05:06Z

@docker/core-machine-maintainers machine will need some updates to support the new experimental flag.

LGTM

thaJeztah · 2016-10-24T21:54:58Z

docs/reference/api/docker_remote_api.md

Missing "header", I guess?

Every API response now includes a `Docker-Experimental` header specifying if experimental features are enabled (value can be `true` or `false`).

thaJeztah · 2016-10-24T22:09:46Z

Had one small nit on docs, but feel free to go ahead if you prefer

Signed-off-by: Kenfe-Mickael Laventure <[email protected]>

mlaventure · 2016-10-24T22:20:24Z

@thaJeztah made the doc change.

thaJeztah

LGTM

thaJeztah · 2016-10-24T23:58:21Z

all green!

See boot2docker/boot2docker#1218 and moby/moby#27223

tianon · 2016-12-14T17:20:01Z

https://github.com/docker/docker/blob/master/experimental/README.md should probably be updated for this change as well, right?

thaJeztah · 2016-12-14T17:28:38Z

@tianon see #28160 ❤️

praving55 · 2017-01-19T03:27:46Z

Can you point me to the reference please? I could not see it in docs

thaJeztah · 2017-01-19T14:49:33Z

docs for 1.13 are not yet published, but the flag itself is documented in the dockerd reference. You can either set a --experimental flag on the daemon (but depends on what init system (upstart, sysv-init, systemd) you're using, or use a daemon.json configuration file, as described here; https://github.com/docker/docker/blob/v1.13.0/docs/reference/commandline/dockerd.md#daemon-configuration-file

praving55 · 2017-01-19T15:02:01Z

Is there a reason docs are lagging? I never saw that happening before.

thaJeztah · 2017-01-19T16:10:40Z

Not all parts of the release are released yet, so the release will be officially announced after all projects have finished their release, and the docs will probably go out together with that.

praving55 · 2017-01-19T22:13:27Z

ok

GordonTheTurtle added the status/0-triage label Oct 7, 2016

mlaventure force-pushed the merge-experimental branch 3 times, most recently from 1cf6f42 to 6ed62b5 Compare October 10, 2016 13:52

justincormack added status/1-design-review and removed status/0-triage labels Oct 11, 2016

AkihiroSuda reviewed Oct 13, 2016

View reviewed changes

mlaventure force-pushed the merge-experimental branch 5 times, most recently from bba1b28 to da64999 Compare October 14, 2016 21:02

icecrime added status/2-code-review and removed status/1-design-review labels Oct 19, 2016

icecrime assigned LK4D4 and justincormack Oct 19, 2016

icecrime added this to the 1.13.0 milestone Oct 19, 2016

vdemeester added impact/changelog impact/documentation labels Oct 20, 2016

mlaventure force-pushed the merge-experimental branch 2 times, most recently from ec36188 to f522adf Compare October 20, 2016 17:29

tianon reviewed Oct 20, 2016

View reviewed changes

mlaventure force-pushed the merge-experimental branch from f522adf to 71147c5 Compare October 20, 2016 23:08

vieux approved these changes Oct 24, 2016

View reviewed changes

thaJeztah reviewed Oct 24, 2016

View reviewed changes

Make experimental a runtime flag

7781a1b

Signed-off-by: Kenfe-Mickael Laventure <[email protected]>

mlaventure force-pushed the merge-experimental branch from 5d3eebb to 7781a1b Compare October 24, 2016 22:20

thaJeztah approved these changes Oct 24, 2016

View reviewed changes

thaJeztah added status/4-merge and removed status/2-code-review labels Oct 24, 2016

thaJeztah merged commit ba41a5e into moby:master Oct 24, 2016

albers mentioned this pull request Oct 25, 2016

Add bash completion for dockerd --experimental #27721

Merged

sdurrheimer mentioned this pull request Oct 25, 2016

Add zsh completion for 'dockerd --experimental' #27724

Merged

mlaventure deleted the merge-experimental branch October 25, 2016 15:49

thaJeztah mentioned this pull request Nov 6, 2016

Changing the definition of experimental #26713

Closed

4 tasks

This was referenced Nov 8, 2016

[EXPERIMENTAL] new mount type: introspection #26331

Closed

update experimental/README.md #28160

Merged

tianon mentioned this pull request Nov 14, 2016

Remove "Dockerfile.experimental" now that experimental is a daemon runtime flag instead boot2docker/boot2docker#1218

Merged

tianon added a commit to tianon/jenkins-groovy that referenced this pull request Nov 14, 2016

No longer build boot2docker-experimental.iso

a977f6d

See boot2docker/boot2docker#1218 and moby/moby#27223

tuxity mentioned this pull request Jan 19, 2017

[WIP] Docker 1.13 drone-plugins/drone-docker#100

Merged

5 tasks

tianon mentioned this pull request Jun 25, 2019

Provide release ISO for experimental boot2docker/boot2docker#1061

Closed

Conversation

mlaventure commented Oct 7, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

icecrime commented Oct 17, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

icecrime commented Oct 19, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

justincormack commented Oct 20, 2016

Uh oh!

LK4D4 commented Oct 20, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

thaJeztah commented Oct 20, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vdemeester commented Oct 24, 2016

Uh oh!

vieux left a comment

Choose a reason for hiding this comment

Uh oh!

ehazlett commented Oct 24, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

thaJeztah commented Oct 24, 2016

Uh oh!

mlaventure commented Oct 24, 2016

Uh oh!

thaJeztah left a comment

Choose a reason for hiding this comment

Uh oh!

thaJeztah commented Oct 24, 2016

Uh oh!

tianon commented Dec 14, 2016

Uh oh!

thaJeztah commented Dec 14, 2016

Uh oh!

praving55 commented Jan 19, 2017

Uh oh!

thaJeztah commented Jan 19, 2017

Uh oh!

praving55 commented Jan 19, 2017

Uh oh!

thaJeztah commented Jan 19, 2017

Uh oh!

praving55 commented Jan 19, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

mlaventure commented Oct 7, 2016 •

edited

Loading

icecrime commented Oct 17, 2016 •

edited

Loading

icecrime commented Oct 19, 2016 •

edited

Loading