Conversation
Signed-off-by: Tonis Tiigi <[email protected]>
|
LGTM |
|
SGTM |
|
Overall LGTM.
Not sure we should make a behavioral change now since we are deprecating it anyway. But I don't have a strong opinion.
|
|
@aaronlehmann It's just restoring the old behavior so that it is safer during the deprecation period and doesn't cause accidental collisions(for example if someone uses tags like |
|
|
||
| **Target For Removal In Release: v1.16** | ||
|
|
||
| `repository:shortid` syntax for referencing images is very little used, collides with with tag references can be confused with digest references. |
There was a problem hiding this comment.
This needs to be opened against the https://github.com/docker/docker.github.io repository
There was a problem hiding this comment.
What branch? Master branch looks outdated and is seems to be missing at least 3 recent changes.
There was a problem hiding this comment.
@tonistiigi I have no idea; it looks like "master" on docker.github.io was taken from the 1.12.x branch, but all changes for 1.13 are not there
There was a problem hiding this comment.
|
@tonistiigi does the minimum length mean that I can no longer tag (or pull) an image with a tag |
|
@thaJeztah The length limit is only for the partial IDs, not tags. |
|
@ncdc FYI |
|
LGTM |
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM
docs are handled in docker/docs#184
8 participants
fixes #22112
Per discussion in #22112 deprecate this little known feature. The minimum length requirement from
v1.9has also been restored.@thaJeztah @duglin
Signed-off-by: Tonis Tiigi [email protected]