Skip to content

Fix #2342. Harmonize information about ADD. Cross-link build info.#2717

Merged
metalivedev merged 1 commit intomoby:masterfrom
metalivedev:2342-uploadingcontext
Nov 21, 2013
Merged

Fix #2342. Harmonize information about ADD. Cross-link build info.#2717
metalivedev merged 1 commit intomoby:masterfrom
metalivedev:2342-uploadingcontext

Conversation

@metalivedev
Copy link
Copy Markdown
Contributor

Fixes #2342

Comment thread docs/sources/commandline/cli.rst Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't it send up everything in the context directory, regardless of whether anything is ADDed? Because otherwise, the client would have to parse the Dockerfile also, to figure out what needs to be included in said context.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I've read through the code, and I agree, unless the argument is - the whole directory is always uploaded. I don't know where this stuff about absolute paths came from. I reviewed the code back at 0.5.3 and the behavior is the same, so it is not a recent change. I'll update the text to remove this nonsense.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the argument is -, the context is automatically empty, isn't it?

@ghost ghost assigned kencochrane Nov 18, 2013
@metalivedev
Copy link
Copy Markdown
Contributor Author

ping @kencochrane for review

Comment thread docs/sources/commandline/cli.rst Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thsre -> there :)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh!

@metalivedev
Copy link
Copy Markdown
Contributor Author

squashed

@kencochrane
Copy link
Copy Markdown
Contributor

@metalivedev it looks good to me, but we should probably get @crosbymichael or @vieux or someone else to also look, to be sure.

@vieux
Copy link
Copy Markdown
Contributor

vieux commented Nov 21, 2013

LGTM

@crosbymichael
Copy link
Copy Markdown
Contributor

ping @metalivedev

LGTM

metalivedev pushed a commit that referenced this pull request Nov 21, 2013
Fix #2342. Harmonize information about ADD. Cross-link build info.
@metalivedev metalivedev merged commit 9b4c151 into moby:master Nov 21, 2013
@metalivedev metalivedev deleted the 2342-uploadingcontext branch November 21, 2013 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

What is the meaning of "Uploading context" when executing docker build?

6 participants