Fix #2342. Harmonize information about ADD. Cross-link build info.#2717
Fix #2342. Harmonize information about ADD. Cross-link build info.#2717metalivedev merged 1 commit intomoby:masterfrom metalivedev:2342-uploadingcontext
Conversation
There was a problem hiding this comment.
Doesn't it send up everything in the context directory, regardless of whether anything is ADDed? Because otherwise, the client would have to parse the Dockerfile also, to figure out what needs to be included in said context.
There was a problem hiding this comment.
Ok, I've read through the code, and I agree, unless the argument is - the whole directory is always uploaded. I don't know where this stuff about absolute paths came from. I reviewed the code back at 0.5.3 and the behavior is the same, so it is not a recent change. I'll update the text to remove this nonsense.
There was a problem hiding this comment.
If the argument is -, the context is automatically empty, isn't it?
|
ping @kencochrane for review |
|
squashed |
|
@metalivedev it looks good to me, but we should probably get @crosbymichael or @vieux or someone else to also look, to be sure. |
|
LGTM |
|
ping @metalivedev LGTM |
Fix #2342. Harmonize information about ADD. Cross-link build info.
Fixes #2342