Fix cli/command/service/opts_test.go, and add some extra test cases#26951
Merged
cpuguy83 merged 1 commit intomoby:masterfrom Sep 28, 2016
Merged
Fix cli/command/service/opts_test.go, and add some extra test cases#26951cpuguy83 merged 1 commit intomoby:masterfrom
cpuguy83 merged 1 commit intomoby:masterfrom
Conversation
`m.Set("type=volume,target=/foo,volume-nocopy")` is valid even though it lacks "source"
Signed-off-by: Akihiro Suda <[email protected]>
Contributor
|
LGTM @cpuguy83 Please verify that source isn't required for volume mount. |
Member
|
Yes, I think this will be fine. I checked docs and I think we're ok there as well. |
dnephin
pushed a commit
to dnephin/docker
that referenced
this pull request
Apr 17, 2017
…service Fix cli/command/service/opts_test.go, and add some extra test cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For suggestions from @stevvooe
https://github.com/docker/docker/pull/26825/files/563986b0a9d2b07777f2ee9ca9462f13208fa2d8#r80338930: add test cases for volumes
https://github.com/docker/docker/pull/26825/files/563986b0a9d2b07777f2ee9ca9462f13208fa2d8#r80338995: add a test case for
readonly=truehttps://github.com/docker/docker/pull/26825/files/563986b0a9d2b07777f2ee9ca9462f13208fa2d8#r80339035:
m.Set("type=volume,target=/foo,volume-nocopy")is valid even though it lacks "source"#26825 depends on this PR
Signed-off-by: Akihiro Suda [email protected]