Minor code simplification for Containers api#2678
Merged
crosbymichael merged 1 commit intomoby:masterfrom Nov 22, 2013
Merged
Conversation
Contributor
|
could you please Thanks, LGTM, ping @creack @crosbymichael |
Contributor
Author
|
@vieux thanks, I did "gofmt -w -s server.go", but it does not show a diff here. |
Contributor
|
I do see them, there is one space |
Member
|
Perhaps a go version issue? You could try doing it from inside the docker container with a mounted volume. |
Contributor
Author
|
This is kinda weird.. I tried 1.0.1, 1.1.2, 1.2rc4 linux amd64 binary of go. All of them gave me the same result, @tianon I tried that too. I can get a diff for server_test.go but not server.go. |
Contributor
|
@cxmcc fixed in master ping @crosbymichael |
Contributor
|
LGTM |
crosbymichael
added a commit
that referenced
this pull request
Nov 22, 2013
Minor code simplification for Containers api
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a little bit simpler. Also should stop comparing container ids when "beforeId" is found.