Windows: Write fatal error to event log if running as service#26725
Merged
vdemeester merged 1 commit intomoby:masterfrom Sep 20, 2016
Merged
Windows: Write fatal error to event log if running as service#26725vdemeester merged 1 commit intomoby:masterfrom
vdemeester merged 1 commit intomoby:masterfrom
Conversation
Signed-off-by: Stefan Scherer <[email protected]>
StefanScherer
changed the title
Member
|
LGTM |
Member
|
LGTM |
Member
|
win2lin failure unrelated… |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
I've updated a TP5 machine to use the latest docker-1.13.0-dev.zip binaries. But I couldn't start the Windows Service docker. I found no useful information in the Event log viewer.
Only after starting the
dockerd.exemanually I found a message on stdout that TP5 seems to be too old:The message is swallowed if
dockerd.exeis started as a service as discussed here. So I looked for a good place to log that error with logrus to the Event log.- How I did it
- How to verify it
Install the binaries on TP5 and try to start the service and have a look at the Event log.
- Description for the changelog
Write fatal error to the Windows event log when the service could not be started.
- A picture of a cute animal (not mandatory but encouraged)
Not an animal, but the result of this PR:
Signed-off-by: Stefan Scherer [email protected]