Windows: OCI remove first start#26650
Merged
cpuguy83 merged 1 commit intomoby:masterfrom Sep 18, 2016
Merged
Conversation
jstarks
suggested changes
Sep 16, 2016
Contributor
There was a problem hiding this comment.
IgnoreFlush is a little misleading since this is just during boot.
Signed-off-by: John Howard <[email protected]>
lowenna
force-pushed
the
jjh/firststart
branch
from
049d837 to
f7fd408
Compare
Contributor
|
LGTM |
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Howard [email protected]
This PR moves Windows a little closer to OCI compliance for the runtime spec. There are no functional changes in the PR. In the proof of concept PR opencontainers/runtime-spec#504, there was a comment from @wking opencontainers/runtime-spec#504 (comment) that (rightly) the first start flag didn't belong in the spec and should be moved to the runtime.
This PR does exactly that, and handles the first start optimisation on Windows through a
CreateOptionto libcontainerd.@mlaventure @tonistiigi PTAL.
/cc @jstarks FYI