Skip to content

progress: Rate limit progress bar output#26584

Merged
LK4D4 merged 1 commit intomoby:masterfrom
aaronlehmann:rate-limit-progress-bar
Sep 15, 2016
Merged

progress: Rate limit progress bar output#26584
LK4D4 merged 1 commit intomoby:masterfrom
aaronlehmann:rate-limit-progress-bar

Conversation

@aaronlehmann
Copy link
Copy Markdown

ProgressReader outputs progress information every 500 KB. This could be
excessive if something is being transfered at a fast rate. Rate-limit
progress output to 10 per second.

Fixes #11971

@tonistiigi tonistiigi added status/2-code-review status/failing-ci Indicates that the PR in its current state fails the test suite and removed status/0-triage labels Sep 15, 2016
@tonistiigi
Copy link
Copy Markdown
Member

@aaronlehmann unit-test failure in ci

ProgressReader outputs progress information every 500 KB. This could be
excessive if something is being transfered at a fast rate. Rate-limit
progress output to 10 per second.

Signed-off-by: Aaron Lehmann <[email protected]>
@aaronlehmann aaronlehmann force-pushed the rate-limit-progress-bar branch from c839723 to f8eab6f Compare September 15, 2016 00:23
@aaronlehmann
Copy link
Copy Markdown
Author

Fixed

Copy link
Copy Markdown
Member

@tonistiigi tonistiigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tonistiigi tonistiigi added status/4-merge and removed status/failing-ci Indicates that the PR in its current state fails the test suite status/2-code-review labels Sep 15, 2016
@stevvooe
Copy link
Copy Markdown
Contributor

LGTM

@LK4D4
Copy link
Copy Markdown
Contributor

LK4D4 commented Sep 15, 2016

experimental failure is unrelated

@LK4D4 LK4D4 merged commit b248de7 into moby:master Sep 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants