Windows: Move to fstab options as per OCI#26577
Conversation
|
ping @crosbymichael @stevvooe PTAL |
There was a problem hiding this comment.
Could you add a newline before }? This looks very weird.
There was a problem hiding this comment.
Sure. Will do in the morning. It's what gofmt did though...
There was a problem hiding this comment.
Odd. Did it pull up the newline?
There was a problem hiding this comment.
@stevvooe Turns out if you omit the last ,, a } on the same line is syntactically correct for the compiler and for godoc. However, if you put the } on a new line, the compiler requires the trailing comma. Learn something every day 😇
Anyway, put the brace on the new line instead and pushed an update.
There was a problem hiding this comment.
Is this change backwards compatible?
There was a problem hiding this comment.
Fortunately that's not a concern on Windows yet :)
Signed-off-by: John Howard <[email protected]>
lowenna
force-pushed
the
jjh/fstabmount
branch
from
1649559 to
bb585b9
Compare
|
LGTM @stevvooe can you leave your LGTM? (I know the new GitHub features are cool, but I think we still need a 'LGTM') |
|
@mlaventure @tonistiigi PTAL. Thanks. |
5 participants
Signed-off-by: John Howard [email protected]
No functional changes. Minor update to the currently hacked non-OCI compliant
specused in Windows to get closer to OCI compliance. Instead of an explicit readonly field, uses thefstabstyle options as per the current OCI spec (even though fstab is strictly meaningless on Windows).The mount structure is now identical to https://github.com/opencontainers/runtime-spec/blob/master/specs-go/config.go#L84-L95