Add zsh completion for 'service {create,update} --group-{add,rm}'#26478
Merged
vdemeester merged 1 commit intomoby:masterfrom Sep 13, 2016
Merged
Conversation
Member
|
LGTM |
contrib/completion/zsh/_docker
Outdated
Member
There was a problem hiding this comment.
Is this correct? --group-add is available for both docker service update and docker service create but --group-rm is only available for docker service update (sorry for the misleading subject that I gave to my PR)
Contributor
Author
There was a problem hiding this comment.
Woops, my bad. Fixed !
Signed-off-by: Steve Durrheimer <[email protected]>
sdurrheimer
force-pushed
the
zsh-completion-service-group-add-rm
branch
from
759d536 to
1df220d
Compare
Member
|
LGTM 🐸 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref. #25317
@albers Thx for the ping
Signed-off-by: Steve Durrheimer [email protected]