Correctly express "any address" to iptables.#2633
Merged
crosbymichael merged 1 commit intomoby:masterfrom Nov 11, 2013
danderson:2598-fix-iptables-anydest
Merged
Correctly express "any address" to iptables.#2633crosbymichael merged 1 commit intomoby:masterfrom danderson:2598-fix-iptables-anydest
crosbymichael merged 1 commit intomoby:masterfrom
danderson:2598-fix-iptables-anydest
Conversation
Iptables interprets "-d 0.0.0.0" as "-d 0.0.0.0/32", not /0. This results in the DNAT rule never matching any traffic if not bound to a specific host IP. Fixes #2598
Contributor
|
LGTM |
Contributor
|
LGTM, @crosbymichael could you take a look just to be sure ? |
Contributor
|
LGTM |
crosbymichael
added a commit
that referenced
this pull request
Nov 11, 2013
Correctly express "any address" to iptables.
Contributor
|
Why would you simply not omit the '-d' if you want to match any address? |
Contributor
Author
|
I originally wrote it as you suggest, but that ends up splitting the iptables commandline over 3 statements - prelude, optional -d, epilogue. Overall, it made the code less readable than keeping the commandline in a single statement. And "-d 0/0" is indistinguishable from no -d if you look at netfilter's configuration dumps (iptables -t nat -Lnvv), so I decided to go with the version that doesn't split the commandline up. But it's certainly possible to do it the other way as well. |
Contributor
|
All good reasons! :-) |
|
@danderson Now the latest version doesn't work? |
This was referenced Jun 19, 2018
cpuguy83
pushed a commit
to cpuguy83/docker
that referenced
this pull request
May 25, 2021
Enforce order of lock acquisitions on network/controller, fixes moby#2632
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Iptables interprets "-d 0.0.0.0" as "-d 0.0.0.0/32", not /0. This
results in the DNAT rule never matching any traffic if not bound
to a specific host IP.
Fixes #2598