Improve documentation for builder.rst / VOLUME command#2632
Closed
codevin wants to merge 1 commit intomoby:masterfrom
Closed
Improve documentation for builder.rst / VOLUME command#2632codevin wants to merge 1 commit intomoby:masterfrom
codevin wants to merge 1 commit intomoby:masterfrom
Conversation
Updated builder.rst to make VOLUME command documentation more precise and avoid confusion.
Contributor
|
/cc @metalivedev |
ghost
assigned
Contributor
|
Howdy -- thank you for this improvement, but there are some problems:
I agree that if you're looking at the Could you update your pull request? /Andy |
Contributor
Author
|
How about this line? Essentially bringing out the behaviour explicitly in one line. Also note that I am using the term "mount point", which seems appropriate. Is this OK? |
Contributor
|
Your sentence sounds fine. Thanks! |
Contributor
|
fixed in #2690 |
thaJeztah
added a commit
to thaJeztah/docker
that referenced
this pull request
May 25, 2021
…91130ec8 Update libnetwork to make `docker run -p 80:80` functional again on environments with kernel boot parameter `ipv6.disable=1`. full diff: moby/libnetwork@b350742...64b7a45 - fix port forwarding with ipv6.disable=1 - fixes moby/moby/42288 Docker 20.10.6: all containers stopped and cannot start if ipv6 is disabled on host - fixes docker/libnetwork/2629 Network issue with IPv6 following update to version 20.10.6 - fixesdocker/for-linux/1233 Since 20.10.6 it's not possible to run docker on a machine with disabled IPv6 interfaces - vendor: github.com/ishidawataru/sctp f2269e66cdee387bd321445d5d300893449805be - Enforce order of lock acquisitions on network/controller, fixes moby#2632 - fixes docker/libnetwork/2632 Name resolution stuck due to deadlock between different network struct methods - fixes moby/moby/42032 Docker deamon get's stuck, can't serve DNS requests Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added a commit
to thaJeztah/docker
that referenced
this pull request
May 25, 2021
…91130ec8 Update libnetwork to make `docker run -p 80:80` functional again on environments with kernel boot parameter `ipv6.disable=1`. full diff: moby/libnetwork@b350742...64b7a45 - fix port forwarding with ipv6.disable=1 - fixes moby/moby/42288 Docker 20.10.6: all containers stopped and cannot start if ipv6 is disabled on host - fixes docker/libnetwork/2629 Network issue with IPv6 following update to version 20.10.6 - fixesdocker/for-linux/1233 Since 20.10.6 it's not possible to run docker on a machine with disabled IPv6 interfaces - vendor: github.com/ishidawataru/sctp f2269e66cdee387bd321445d5d300893449805be - Enforce order of lock acquisitions on network/controller, fixes moby#2632 - fixes docker/libnetwork/2632 Name resolution stuck due to deadlock between different network struct methods - fixes moby/moby/42032 Docker deamon get's stuck, can't serve DNS requests Signed-off-by: Sebastiaan van Stijn <[email protected]> (cherry picked from commit e4109b3) Signed-off-by: Sebastiaan van Stijn <[email protected]>
cpuguy83
pushed a commit
to cpuguy83/docker
that referenced
this pull request
May 25, 2021
…2632 Signed-off-by: Francesco Degrassi <[email protected]>
cpuguy83
pushed a commit
to cpuguy83/docker
that referenced
this pull request
May 25, 2021
Enforce order of lock acquisitions on network/controller, fixes moby#2632
nosamad
pushed a commit
to WAGO/docker-engine
that referenced
this pull request
Sep 13, 2021
…91130ec8 Update libnetwork to make `docker run -p 80:80` functional again on environments with kernel boot parameter `ipv6.disable=1`. full diff: moby/libnetwork@b350742...64b7a45 - fix port forwarding with ipv6.disable=1 - fixes moby/moby/42288 Docker 20.10.6: all containers stopped and cannot start if ipv6 is disabled on host - fixes docker/libnetwork/2629 Network issue with IPv6 following update to version 20.10.6 - fixesdocker/for-linux/1233 Since 20.10.6 it's not possible to run docker on a machine with disabled IPv6 interfaces - vendor: github.com/ishidawataru/sctp f2269e66cdee387bd321445d5d300893449805be - Enforce order of lock acquisitions on network/controller, fixes moby#2632 - fixes docker/libnetwork/2632 Name resolution stuck due to deadlock between different network struct methods - fixes moby/moby/42032 Docker deamon get's stuck, can't serve DNS requests Signed-off-by: Sebastiaan van Stijn <[email protected]> (cherry picked from commit e4109b3) Signed-off-by: Sebastiaan van Stijn <[email protected]>
nosamad
pushed a commit
to WAGO/docker-engine
that referenced
this pull request
Sep 15, 2021
…91130ec8 Update libnetwork to make `docker run -p 80:80` functional again on environments with kernel boot parameter `ipv6.disable=1`. full diff: moby/libnetwork@b350742...64b7a45 - fix port forwarding with ipv6.disable=1 - fixes moby/moby/42288 Docker 20.10.6: all containers stopped and cannot start if ipv6 is disabled on host - fixes docker/libnetwork/2629 Network issue with IPv6 following update to version 20.10.6 - fixesdocker/for-linux/1233 Since 20.10.6 it's not possible to run docker on a machine with disabled IPv6 interfaces - vendor: github.com/ishidawataru/sctp f2269e66cdee387bd321445d5d300893449805be - Enforce order of lock acquisitions on network/controller, fixes moby#2632 - fixes docker/libnetwork/2632 Name resolution stuck due to deadlock between different network struct methods - fixes moby/moby/42032 Docker deamon get's stuck, can't serve DNS requests Signed-off-by: Sebastiaan van Stijn <[email protected]> (cherry picked from commit e4109b3) Signed-off-by: Sebastiaan van Stijn <[email protected]>
nosamad
pushed a commit
to WAGO/docker-engine
that referenced
this pull request
Sep 28, 2021
…91130ec8 Update libnetwork to make `docker run -p 80:80` functional again on environments with kernel boot parameter `ipv6.disable=1`. full diff: moby/libnetwork@b350742...64b7a45 - fix port forwarding with ipv6.disable=1 - fixes moby/moby/42288 Docker 20.10.6: all containers stopped and cannot start if ipv6 is disabled on host - fixes docker/libnetwork/2629 Network issue with IPv6 following update to version 20.10.6 - fixesdocker/for-linux/1233 Since 20.10.6 it's not possible to run docker on a machine with disabled IPv6 interfaces - vendor: github.com/ishidawataru/sctp f2269e66cdee387bd321445d5d300893449805be - Enforce order of lock acquisitions on network/controller, fixes moby#2632 - fixes docker/libnetwork/2632 Name resolution stuck due to deadlock between different network struct methods - fixes moby/moby/42032 Docker deamon get's stuck, can't serve DNS requests Signed-off-by: Sebastiaan van Stijn <[email protected]> (cherry picked from commit e4109b3) Signed-off-by: Sebastiaan van Stijn <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated builder.rst to make VOLUME command documentation more precise and avoid confusion.