Add ImageInsert tests#2603
Conversation
|
Ping @creack |
|
Thanks @mrallen1 and @dsissitka. |
There was a problem hiding this comment.
I think this is a behaviour change. If some script was parsing inject's output.
It'll be broken
There was a problem hiding this comment.
Also, please to not truncate ID and return the full one.
There was a problem hiding this comment.
@vieux Inject or insert? If insert, it is a behavior change because insert used to shit in your terminal:
$ docker insert 8dbd9 https://www.docker.io/static/img/docker-top-logo.png /foo
5765ac1d7336c1d805f04e745b7fdc9583bb23202a825c6e26c933b636a357cd
5765ac1d7336:
$
There was a problem hiding this comment.
insert, ok it's a change. But please return only long ID to be easily parseable.
There was a problem hiding this comment.
Perhaps I'm overlooking something but it seems like that'd be inconsistent. See, for example, ImageImport. It uses ProgressReader and returns a short ID.
There was a problem hiding this comment.
there is an ongoing PR to return long ids everywhere
Return long image ID Return streamformatted error or "raw" error
|
@vieux I just added a commit to reflect your review comments. (All tests still pass.) Thanks. |
There was a problem hiding this comment.
I'm sorry, but could you just return the id + out.Write(sf.FormatStatus(img.ID, ""))
Thanks
|
OK, sure. :) ping @vieux |
|
LGTM, merged manually |
Fixed IPv6 portmapper iptables chain initialization
4 participants
Closes #1130
Incorporates #1942
Test that the insert command returns errors and reports success appropriately.
All tests pass.