Deprecate old tagging format#2597
Merged
crosbymichael merged 1 commit intomasterfrom Nov 8, 2013
Merged
Conversation
Member
|
+1 |
Contributor
|
IMO, The error message look like it didn't work. Maybe add something like "next time" at the end ? |
Contributor
|
Otherwise LGTM |
Contributor
Author
|
a deprecated message is meant to be scary. If someone use it manually, there is no problem if he thinks it failed. If it is used by a script, then it will still work as the message is printed on stderr. |
Contributor
|
ping @shykes @crosbymichael |
|
I only play a developer on TV, but obtuse error messages are never good UX. It should always be clear whether a command succeeded or not. |
Contributor
Author
|
@binaryphile The exit code is 100% clear to show success/failure. |
Contributor
|
LGTM |
crosbymichael
added a commit
that referenced
this pull request
Nov 8, 2013
Deprecate old tagging format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.