- Fix the attach examples according to the new 'attach' behavior#2592
- Fix the attach examples according to the new 'attach' behavior#2592rogaha wants to merge 2 commits intomoby:masterfrom
Conversation
rogaha
commented
Nov 7, 2013
rogaha
commented
- Add the option of adding the user to docker's group and avoid the usage of "sudo" before each command to 'use->basic' section.
- Add the option of adding the user to docker's group and avoid the usage of "sudo" before each command
|
Wouldn't it be better to switch back to the original behavior? /cc @shykes @crosbymichael @vieux |
|
I think it makes more sense the old behavior by default, but it's not big deal since we have that option flag. |
|
This feels like a general note you could add to the examples as an include - "These examples use sudo you could also blah." |
|
Hi @jamtur01, good idea! I'll add it to the examples in general! |
ghost
assigned
|
Hey guys, I am happy to discuss possible changes in behavior, but we should discuss it somewhere else (#docker-dev or the docker-dev mailing list). In any case the docs should always be up-to-date with the current behavior. So I will focus on that for now. |
|
LGTM /cc @metalivedev |
There was a problem hiding this comment.
This section is redundant. The next code sample does the same thing.
|
Thanks @metalivedev! It's better now! 👍 |
|
Replaced by @metalivedev with #2755 |
6 participants
