I understand this is useful, but still, even in debug, I'm not found of displaying HTML in the debug output.

Try: docker pull dsdsa

I think this is an issue from the index. /cc @kencochrane

Just to give some background for this PR, we discussed this feature with Joffrey before. The idea is to make push/pull errors useful for easy debugging. Right now copy/pasting errors are useless and does not bring any info to debug (usually you have to relaunch the deamon in debug, retry and still not have enough data...).

I did not test the PR yet...

Basically when you pull a non-existent image, the body of the 404 is a very large html error page.

​

@samalba @kencochrane I see the reason for the feature, but I think it will be really weird to display tons of html output.

​

Maybe only print the body only if content-type is application/json?

Otherwise maybe we could add a "debug" feature on the index where logged in users could retrieve their failed queries - it's more work but could be a really awesome way to give support.

@solomonstre
@docker

On Mon, Nov 11, 2013 at 8:15 PM, Sam Alba [email protected]
wrote:

Just to give some background for this PR, we discussed this feature with Joffrey before. The idea is to make push/pull errors useful for easy debugging. Right now copy/pasting errors are useless and does not bring any info to debug (usually you have to relaunch the deamon in debug, retry and still not have enough data...).

I did not test the PR yet...

Reply to this email directly or view it on GitHub:
#2587 (comment)

I think we should not print html anyway. But we need the raw content for
other errors. 3 options:

1- print 1024 chars only for the body (then html will be stripped)

2- read the first chars, if we detect html, we don't print it. We print any
other content

3- both

On Tuesday, November 12, 2013, Solomon Hykes wrote:

Basically when you pull a non-existent image, the body of the 404 is a
very large html error page.

​

@samalba @kencochrane I see the reason for the feature, but I think it
will be really weird to display tons of html output.

​

Maybe only print the body only if content-type is application/json?

Otherwise maybe we could add a "debug" feature on the index where logged
in users could retrieve their failed queries - it's more work but could be
a really awesome way to give support.

@solomonstre
@docker

On Mon, Nov 11, 2013 at 8:15 PM, Sam Alba <[email protected]<javascript:_e({}, 'cvml', '[email protected]');>>

wrote:

Just to give some background for this PR, we discussed this feature with
Joffrey before. The idea is to make push/pull errors useful for easy
debugging. Right now copy/pasting errors are useless and does not bring any
info to debug (usually you have to relaunch the deamon in debug, retry and
still not have enough data...).

I did not test the PR yet...

Reply to this email directly or view it on GitHub:
#2587 (comment)

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/2587#issuecomment-28269445
.

@sam_alba

@shin- could you re-open this with a check to only print error body when 1) content-type is application/json and 2) DEBUG is enabled?

Thanks! In the meantime I'm closing this for bookkeeping.

I'd print this even if debug is disabled. It's a PITA to always reply "please retry in debug". It makes the output not useful for understanding a problem. However I agree for the content-type.

Added truncating if response body is longer than 1024 bytes. @samalba @shykes

LGTM

@shin- You can use net/http/httputil to format and dump the response and avoid all these Errorf calls.

@shin- could you update this to match @crosbymichael requirements ?
Also what do you think about generating a .dump file somewhere, instead of printing everything in the daemon log ?

Closing this for now to help with bookkeeping, feel free to reopen when changes are made.