Remove --network-add and --network-rm flags from service update#25646
Merged
tiborvass merged 1 commit intomoby:masterfrom Aug 12, 2016
Merged
Remove --network-add and --network-rm flags from service update#25646tiborvass merged 1 commit intomoby:masterfrom
tiborvass merged 1 commit intomoby:masterfrom
Conversation
tiborvass
added
process/cherry-pick
status/2-code-review
status/3-docs-review
and removed
status/0-triage
labels
tiborvass
force-pushed
the
fix-network-flag-on-service-update
branch
2 times, most recently
from
aa8d91f to
be3a31b
Compare
These flags were not supported (daemon returns an error), and it was an oversight. They were not present in completion scripts. Signed-off-by: Tibor Vass <[email protected]>
tiborvass
force-pushed
the
fix-network-flag-on-service-update
branch
from
be3a31b to
3a7e90c
Compare
Contributor
|
LGTM (cc @mrjana) |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These flags were not supported (daemon returns an error), and it was an
oversight. They were not present in completion scripts.
Signed-off-by: Tibor Vass [email protected]