Skip to content

contrib: Desktop integration. Firefox usecase.#2563

Merged
tianon merged 1 commit intomoby:masterfrom
mzdaniel:desktop-integration
Nov 5, 2013
Merged

contrib: Desktop integration. Firefox usecase.#2563
tianon merged 1 commit intomoby:masterfrom
mzdaniel:desktop-integration

Conversation

@mzdaniel
Copy link
Copy Markdown
Contributor

@mzdaniel mzdaniel commented Nov 5, 2013

Add common docker usecases in the desktop

@creack
Copy link
Copy Markdown
Contributor

creack commented Nov 5, 2013

LGTM

@tianon
Copy link
Copy Markdown
Member

tianon commented Nov 5, 2013

Please excuse me while I clean up my drool for the awesome that is this. I will definitely be reviewing this the moment I get back from lunch.

@vieux
Copy link
Copy Markdown
Contributor

vieux commented Nov 5, 2013

I don't like the .dck it's not a good practice, I think we should keep 2 directories with Dockerfile inside

@tianon
Copy link
Copy Markdown
Member

tianon commented Nov 5, 2013

So many kudos here (and I definitely agree with @vieux, so thanks for changing that 👍).

As one final tweak, I'd recommend you switch from tianon/debian to from tianon/debian:wheezy so that when jessie becomes stable (and thus our "latest" tag), we don't have odd behavior with your hard replacement of "/etc/apt/sources.list" to add contrib (which might even be worth switching to something like we've got in the docker-registry to add the universe: https://github.com/dotcloud/docker-registry/blob/master/Dockerfile#L3 - the benefits being that you then get to keep "-updates" and "security" repos, and upgrading the image to "jessie" at some point becomes extremely trivial).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh, this isn't exactly correct anymore. :)

@mzdaniel
Copy link
Copy Markdown
Contributor Author

mzdaniel commented Nov 5, 2013

Awesome. Thank you for reviewing this @creack, @vieux & @tianon!

@tianon
Copy link
Copy Markdown
Member

tianon commented Nov 5, 2013

Happiness!

tianon added a commit that referenced this pull request Nov 5, 2013
contrib: Desktop integration. Firefox usecase.
@tianon tianon merged commit f3f9f65 into moby:master Nov 5, 2013
@mzdaniel mzdaniel deleted the desktop-integration branch November 5, 2013 22:03
cpuguy83 pushed a commit to cpuguy83/docker that referenced this pull request May 25, 2021
log error instead if disabling IPv6 router advertisement failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants