Make iptable return an error in case of output#2561
Merged
crosbymichael merged 2 commits intomasterfrom Nov 7, 2013
Merged
Conversation
Contributor
Author
|
/cc @crosbymichael |
Member
There was a problem hiding this comment.
Shouldn't these all be "iptables" (plural) ?
Contributor
|
@creack Does iptables not return a non 0 exit code causing an error to be returned by |
Contributor
Author
|
@crosbymichael It does not when there is a warning. And in case of error, it is better to retrieve 1) the error itself and 2) the output returned by iptables. |
Contributor
|
LGTM |
Contributor
|
LGTM |
crosbymichael
added a commit
that referenced
this pull request
Nov 7, 2013
Make iptable return an error in case of output
cpuguy83
pushed a commit
to cpuguy83/docker
that referenced
this pull request
May 25, 2021
testing: remove use of docker/docker/errdefs in tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.