Skip to content

Add myself as an author 7e09c633#2517

Merged
vieux merged 1 commit intomoby:masterfrom
gurjeet:patch-2
Nov 5, 2013
Merged

Add myself as an author 7e09c633#2517
vieux merged 1 commit intomoby:masterfrom
gurjeet:patch-2

Conversation

@gurjeet
Copy link
Copy Markdown
Contributor

@gurjeet gurjeet commented Nov 1, 2013

One of my patches was incorporated into Docker, and at that time I didn't know that I was supposed to add myself into this list of contributors.

Commit ID: 7e09c63

And a few other patches are already in the pipeline.

One of my patches was incorporated into Docker, and at that time I didn't know that I was supposed to add myself into this list of contributors.

Commit ID: 7e09c63

And a few other patches are already in the pipeline.
@creack
Copy link
Copy Markdown
Contributor

creack commented Nov 4, 2013

@gurjeet Thank you for the contribution, it is greatly appreciated. However, it seems a bit lite for the moment for you to be included in the Author file.
As you have other patches in the pipeline, I'll be more than happy to include you in the author file once merged.

@creack creack closed this Nov 4, 2013
@gurjeet
Copy link
Copy Markdown
Contributor Author

gurjeet commented Nov 5, 2013

@tianon
Copy link
Copy Markdown
Member

tianon commented Nov 5, 2013

I was certainly under the impression that AUTHORS was supposed to be a comprehensive list of everyone who has contributed code:

# This file lists all individuals having contributed content to the repository.
# If you're submitting a patch, please add your name here in alphabetical order as part of the patch.
#
# For a list of active project maintainers, see the MAINTAINERS file.
#

@crosbymichael
Copy link
Copy Markdown
Contributor

@gurjeet Yes you are right. @creack has been on vacation and did not see the merge.

LGTM

@crosbymichael crosbymichael reopened this Nov 5, 2013
@vieux
Copy link
Copy Markdown
Contributor

vieux commented Nov 5, 2013

LNGTM

vieux pushed a commit that referenced this pull request Nov 5, 2013
Add gurjeet  as an author
@vieux vieux merged commit 7f79265 into moby:master Nov 5, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants