covert docker (commit|import|tag) to use REPOSITORY[:TAG]#2460
Conversation
|
I agree that the inconsistent syntax should be gotten rid of. It just requires more notification to users of the change, so I didn't want to lower the chances of any fix making it in, which is why I did it backwards-compatible on my original pull request. Just don't want anyone to think I'm in favor of keeping the space-based tag syntax. |
|
rebased. |
There was a problem hiding this comment.
This header style causes a severe warning from Sphinx. Please convert to tilde, ~~~~~~~, to conform to the level 3 headers in this file. Sorry, I know, the level 3 headers seem to change style from file to file, but within a file they need to be consistent or Sphinx complains.
Same for line 179.
… support for REPOSITORY TAG)
|
@metalivedev @vieux @crosbymichael rebased |
|
Doc changes LGTM. Need approval from a Go committer for the other changes. Note that this changes some command line syntax (making it more consistent and better) but it will break people's scripts. Make sure we call this out in our release notes! |
|
LGTM |
…erywhere covert docker (commit|import|tag) to use REPOSITORY[:TAG]
|
This should not have been merged. There is only 1 LGTM. Guys, please don't cold-break existing syntax. If we're going to deprecate commands, we should continue to support the old format with a clear deprecation warning for at least 1 release. |
|
+1. |
|
fixed in #2597 |
Revert "Always configure iptables forward policy"
6 participants
(and remove support for REPOSITORY TAG)
partial fix for #2294, #2149, #2387
mostly, I wonder if the server should also refuse to set a REPOSITORY name that contains a : - thus reserving it as a separator for host, port, path and tag.
secondly, I've not written any tests, and on my system, no tests fail :( - have to get to that when i poke the other issues
Closes #2450
tell me if you want me to make this change backwards compatible - I'm not so sure its worth it in the long term, but it may break people's scripts :/