Skip to content

Uncomment the TasksMax val later in the deb build#24558

Merged
tiborvass merged 1 commit intomoby:masterfrom
clnperez:systemd-hack-redo
Jul 12, 2016
Merged

Uncomment the TasksMax val later in the deb build#24558
tiborvass merged 1 commit intomoby:masterfrom
clnperez:systemd-hack-redo

Conversation

@clnperez
Copy link
Copy Markdown
Contributor

- What I did

- How I did it

- How to verify it

  1. 'make deb'
  2. install the xenial deb and make sure docker info doesn't show "unsupported", and that the service file has an uncommented TasksMax=infinity
  3. install a debian deb and make sure the service file still has the commented-out #TasksMax=infinity

- Description for the changelog

The original sed placement in e82830e was creating packages with an "unsupported" tag in the package name.

Fixes #24197

- A picture of a cute animal (not mandatory but encouraged)
happy chimp

The original sed placement was creating packages with an
"unsupported" tag in the package name.

Fixes #24197

Signed-off-by: Christy Perez [email protected]

The original sed placement was creating packages with an
"unsupported" tag in the package name.

Fixes moby#24197

Signed-off-by: Christy Perez <[email protected]>
@clnperez
Copy link
Copy Markdown
Contributor Author

@tianon Thanks for the help on this and sorry it took so long!

@StefanScherer -- If you've got time could you make sure this one checks out? I'm definitely not trusting myself right now. 😜

@thaJeztah
Copy link
Copy Markdown
Member

Thanks!

ping @mlaventure @tiborvass @tianon PTAL

@thaJeztah thaJeztah added this to the 1.12.0 milestone Jul 12, 2016
@tianon
Copy link
Copy Markdown
Member

tianon commented Jul 12, 2016

Nice, LGTM 👍

@mlaventure
Copy link
Copy Markdown
Contributor

LGTM (IANAM).

Tested it for good mesure, works like a charm!

@tiborvass
Copy link
Copy Markdown
Contributor

LGTM

@StefanScherer
Copy link
Copy Markdown
Contributor

@clnperez I've started a make deb on ARM, but the code change LGTM 😄

@StefanScherer
Copy link
Copy Markdown
Contributor

@clnperez raspbian package still shows normal version, as expected with this PR. 👍

@thaJeztah
Copy link
Copy Markdown
Member

awesome!

@clnperez
Copy link
Copy Markdown
Contributor Author

Thanks @StefanScherer and @mlaventure for the testing! Much appreciated. 💚

@clnperez clnperez deleted the systemd-hack-redo branch March 29, 2017 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make "TasksMax" setting dependent on systemd version

7 participants