Skip to content

Remove execution driver#24501

Merged
tiborvass merged 1 commit intomoby:masterfrom
hqhq:remove_exec_driver
Jul 11, 2016
Merged

Remove execution driver#24501
tiborvass merged 1 commit intomoby:masterfrom
hqhq:remove_exec_driver

Conversation

@hqhq
Copy link
Copy Markdown
Contributor

@hqhq hqhq commented Jul 11, 2016

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

We use containerd and there is no execution driver anymore.

Addresses: #24461

Signed-off-by: Qiang Huang [email protected]

We use containerd and there is no execution driver anymore.

Addresses: moby#24461

Signed-off-by: Qiang Huang <[email protected]>
@hqhq
Copy link
Copy Markdown
Contributor Author

hqhq commented Jul 11, 2016

Engine-api change is in docker-archive-public/docker.engine-api#309

@thaJeztah
Copy link
Copy Markdown
Member

/cc @mlaventure

@mlaventure
Copy link
Copy Markdown
Contributor

LGTM (IANAM).

This was an omission from #20662

Funny it took so long to find.

/cc @tonistiigi

@vdemeester
Copy link
Copy Markdown
Member

LGTM 🐸. Should be put this into 1.12.0 milestone ? (given the amount of changes I would say yes but it's not big deal)

@thaJeztah
Copy link
Copy Markdown
Member

I think adding it would be ok; quick check with @tiborvass if he's okay with it too

@thaJeztah thaJeztah added this to the 1.12.0 milestone Jul 11, 2016
@tonistiigi
Copy link
Copy Markdown
Member

LGTM

@tiborvass
Copy link
Copy Markdown
Contributor

Needs an update to api 1.24 since it gets cherrypicked.

@thaJeztah
Copy link
Copy Markdown
Member

created a PR to fix the docs; #24560

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants