Use service alias and configure service VIP or dns-rr#23542
Merged
cpuguy83 merged 3 commits intomoby:masterfrom Jun 15, 2016
Merged
Use service alias and configure service VIP or dns-rr#23542cpuguy83 merged 3 commits intomoby:masterfrom
cpuguy83 merged 3 commits intomoby:masterfrom
Conversation
icecrime
added
status/2-code-review
status/failing-ci
Contributor
|
needs a rebase |
mavenugo
removed
the
status/failing-ci
Signed-off-by: Madhu Venugopal <[email protected]>
Signed-off-by: Madhu Venugopal <[email protected]>
Signed-off-by: Madhu Venugopal <[email protected]>
Contributor
Author
|
Pulled in appropriate fixes from libnetwork and swarmkit as well. |
Contributor
Author
|
All the tests passed. But the CI failed for unrelated reasons. This PR is required for ping @tiborvass @icecrime |
Member
|
I tested this with |
Contributor
|
LGTM! Thanks |
Contributor
|
Both experimental and janky tests have PASSED, but have timed out: there is most likely tests not cleaning up after themselves (cc @crosbymichael). |
mavenugo
changed the title
Member
|
LGTM |
Contributor
|
@cpuguy83 Added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This depends on moby/swarmkit#974 & moby/libnetwork#1263 to be merged & vendored in.