Skip to content

Migrate ps command to cobra#23373

Merged
LK4D4 merged 1 commit intomoby:masterfrom
capkurmagati:23211-spf13-cobra-ps
Jun 14, 2016
Merged

Migrate ps command to cobra#23373
LK4D4 merged 1 commit intomoby:masterfrom
capkurmagati:23211-spf13-cobra-ps

Conversation

@capkurmagati
Copy link
Copy Markdown
Contributor

@capkurmagati capkurmagati commented Jun 8, 2016

- What I did
Moves the ps command to api/client/container/ps.go and use cobra
A part of #23211.
- How to verify it

docker ps -h
Flag shorthand -h has been deprecated, please use --help

Usage:  docker ps [OPTIONS]

List containers

Options:
  -n, -- int            Show n last created containers (includes all states) (default -1)
  -a, --all             Show all containers (default shows just running)
  -f, --filter value    Filter output based on conditions provided (default [])
      --format string   Pretty-print containers using a Go template
      --help            Print usage
  -l, --latest          Show the latest created container (includes all states)
      --no-trunc        Don't truncate output
  -q, --quiet           Only display numeric IDs
  -s, --size            Display total file sizes

Signed-off-by: Tianyi Wang [email protected]

@vdemeester vdemeester added this to the 1.12.0 milestone Jun 8, 2016
@cpuguy83
Copy link
Copy Markdown
Member

cpuguy83 commented Jun 8, 2016

Needs a gofmt

@capkurmagati
Copy link
Copy Markdown
Contributor Author

capkurmagati commented Jun 8, 2016 •
edited
Loading

@cpuguy83 Thank you very much.
I will check the build log and fix them starting from gofmt and golint.

@capkurmagati capkurmagati force-pushed the 23211-spf13-cobra-ps branch from 1cd88d8 to e67b8f9 Compare June 9, 2016 04:43
@capkurmagati
Copy link
Copy Markdown
Contributor Author

capkurmagati commented Jun 10, 2016

ping @cpuguy83 @vdemeester
Please check this.

@icecrime icecrime modified the milestone: 1.12.0 Jun 13, 2016
@LK4D4
Copy link
Copy Markdown
Contributor

LK4D4 commented Jun 13, 2016

LGTM

@vdemeester
Copy link
Copy Markdown
Member

vdemeester commented Jun 13, 2016

LGTM 🐯 but needs a rebase 👼

@capkurmagati
Migrate ps command to cobra
5a0b53b 
Signed-off-by: Tianyi Wang <[email protected]>
@capkurmagati capkurmagati force-pushed the 23211-spf13-cobra-ps branch from e67b8f9 to 5a0b53b Compare June 14, 2016 03:00
@capkurmagati
Copy link
Copy Markdown
Contributor Author

capkurmagati commented Jun 14, 2016

Done. 🎉

@LK4D4
Copy link
Copy Markdown
Contributor

LK4D4 commented Jun 14, 2016

@capkurmagati great, thanks!

@LK4D4 LK4D4 merged commit c81c131 into moby:master Jun 14, 2016
@thaJeztah thaJeztah added this to the 1.12.0 milestone Jun 14, 2016
@capkurmagati capkurmagati deleted the 23211-spf13-cobra-ps branch June 23, 2016 16:59
@dnephin dnephin mentioned this pull request Jul 18, 2016
Closed
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area/cli Client status/2-code-review

Projects

None yet

Milestone

1.12.0

Development

Successfully merging this pull request may close these issues.

7 participants

@capkurmagati @cpuguy83 @LK4D4 @vdemeester @icecrime @thaJeztah @GordonTheTurtle