Migrate cp command to cobra#23348
Merged
LK4D4 merged 1 commit intomoby:masterfrom Jun 14, 2016
Merged
Conversation
Member
There was a problem hiding this comment.
I think this should be in Long, and Short should be the one line
"Copy files/folders between a container and the local filesystem"
Member
Author
There was a problem hiding this comment.
I tend to agree with you but this breaks current output.
before:
λ docker cp
docker: "cp" requires 2 arguments.
See 'docker cp --help'.
Usage: docker cp [OPTIONS] CONTAINER:SRC_PATH DEST_PATH|-
docker cp [OPTIONS] SRC_PATH|- CONTAINER:DEST_PATH
Copy files/folders between a container and the local filesystem
Use '-' as the source to read a tar archive from stdin
and extract it to a directory destination in a container.
Use '-' as the destination to stream a tar archive of a
container source to stdout
after:
λ ./bundles/latest/dynbinary-client/docker cp
"docker cp" requires exactly 2 argument(s).
See 'docker cp --help'.
Usage: docker cp [OPTIONS] CONTAINER:SRC_PATH DEST_PATH|-
docker cp [OPTIONS] SRC_PATH|- CONTAINER:DEST_PATH
Copy files/folders between a container and the local filesystem
docker cp --help will be the same.
@thaJeztah wdyt ?
vdemeester
force-pushed
the
migrate-cp-to-cobra
branch
from
d2aae87 to
bcc0d6d
Compare
Contributor
|
@vdemeester psst |
Signed-off-by: Vincent Demeester <[email protected]>
vdemeester
force-pushed
the
migrate-cp-to-cobra
branch
from
bcc0d6d to
2e6db51
Compare
Member
Author
|
Rebased and updated 😉 |
Member
|
LGTM |
Contributor
|
Ok, experimental hangs after integration tests pass. |
43 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the cp command to
api/client/container/cp.goand use cobra 🐍.Something a little bit weird about
cpthough is that there is two "Use"…… so I did a little weird thingie but it would be awesome if cobra would support it 👼
/cc @dnephin @thaJeztah @LK4D4 @cpuguy83
🐸
Signed-off-by: Vincent Demeester [email protected]