Use spf13/cobra for docker build#23343
Merged
LK4D4 merged 1 commit intomoby:masterfrom Jun 8, 2016
Merged
Conversation
vdemeester
added
area/cli
vdemeester
force-pushed
the
migrate-build-to-cobra
branch
3 times, most recently
from
6412028 to
9087e6f
Compare
Signed-off-by: Vincent Demeester <[email protected]>
vdemeester
force-pushed
the
migrate-build-to-cobra
branch
from
9087e6f to
60f447b
Compare
Member
|
LGTM |
1 similar comment
Contributor
|
LGTM |
43 tasks
dnephin
pushed a commit
to dnephin/docker
that referenced
this pull request
Apr 17, 2017
Use spf13/cobra for docker build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the build command to
api/client/image/build.goand use cobra 🐍./cc @dnephin @thaJeztah @LK4D4 @cpuguy83
🐸
Signed-off-by: Vincent Demeester [email protected]