Fix failing test of docker rename#23341
Closed
yongtang wants to merge 1 commit intomoby:masterfrom
Closed
Conversation
At the time the pull request: Use spf13/cobra for docker rename moby#23290 was created, there was an issue in cobra so the test `DockerSuite.TestRenameInvalidName` was updated. Now the issue in cobra has been fixed in: Use spf13/cobra for docker import moby#23269 so the test related to `docker rename` (`DockerSuite.TestRenameInvalidName`) needs to be reverted back. This fix is related to spf13/cobra moby#23211. Signed-off-by: Yong Tang <[email protected]>
Member
Author
|
Ping @vdemeester @thaJeztah @dnephin. |
Member
|
Oh! just opened a PR for this; #23340, I'll close this one (sorry!) |
Member
Author
|
@thaJeztah no problem. Thanks for taking care of the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the time the pull request:
Use spf13/cobra for docker rename #23290
was created, there was an issue in cobra so the test
DockerSuite.TestRenameInvalidNamewas updated.Now the issue in cobra has been fixed in:
Use spf13/cobra for docker import #23269
so the test related to
docker rename(
DockerSuite.TestRenameInvalidName) needs to be reverted back.This fix is related to spf13/cobra #23211.
Signed-off-by: Yong Tang [email protected]