Fix TestRenameInvalidName#23340
Merged
thaJeztah merged 1 commit intomoby:masterfrom Jun 7, 2016
Merged
Conversation
Change the test back to what it was before e83dad0 And added an extra test-case to check the output if an incorrect number of arguments is passed. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Member
Author
|
ping @justincormack @vdemeester ptal |
Contributor
|
LGTM |
This was referenced Jun 7, 2016
Member
|
ah right, probably because of the update on |
Member
|
@thaJeztah Now the issue in cobra has been fixed in #23269 Thanks for taking care of that. I didn't notice your pull and created another pull request #23341. Will close #23341 shortly. |
Member
Author
|
@yongtang no problem, thanks! At least we understand why it failed now |
Member
Author
|
I'm merging this; the test passed on all, win2lin was aborted due to a manual trigger |
Member
|
yay \o/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the test back to what it was before e83dad0 (#23290),
and added an extra test-case to check the output if an incorrect number of arguments is passed.
For some reason, this test passed on #23290, but is now failing. It looks like the command executed is
docker rename "" newname, including the quotes, which gives a different error thandocker rename myname