Skip to content

Migrate stats and events command to cobra#23334

Merged
vdemeester merged 1 commit intomoby:masterfrom
WeiZhang555:cobra-stats
Jun 8, 2016
Merged

Migrate stats and events command to cobra#23334
vdemeester merged 1 commit intomoby:masterfrom
WeiZhang555:cobra-stats

Conversation

@WeiZhang555
Copy link
Copy Markdown
Contributor

part of #23211

Signed-off-by: Zhang Wei [email protected]

@WeiZhang555 WeiZhang555 force-pushed the cobra-stats branch 2 times, most recently from ca5cb7e to 55f7369 Compare June 7, 2016 04:12
@vdemeester
Copy link
Copy Markdown
Member

@WeiZhang555 I wondet about the move of events in the container package as events are not only for containers so the command is not only for containers 😇

@WeiZhang555
Copy link
Copy Markdown
Contributor Author

@vdemeester Oh no, you're definitely right.

How about moving events to a new package named "system", this will make it consistent with api/server/router/system where events API inhabits in.

stats can still keep in package container. WDYT?

@vdemeester
Copy link
Copy Markdown
Member

@WeiZhang555 yeah make sense I think 😉
stats is a container thing so yeah, container package is about right 👼

@WeiZhang555
Copy link
Copy Markdown
Contributor Author

@vdemeester Updated. PTAL.

@thaJeztah thaJeztah added the status/failing-ci Indicates that the PR in its current state fails the test suite label Jun 7, 2016
@thaJeztah
Copy link
Copy Markdown
Member

@WeiZhang555 CI failures look related;

5:15:59 ---> Making bundle: validate-vet (in bundles/1.12.0-dev/validate-vet)
15:15:59 api/client/system/events_utils.go:29: Handle passes lock by value: system.eventHandler contains sync.Mutex
15:15:59 api/client/system/events_utils.go:38: Watch passes lock by value: system.eventHandler contains sync.Mutex
15:15:59 exit status 1
15:16:00 Unable to find image 'busybox:latest' locally

@WeiZhang555
Copy link
Copy Markdown
Contributor Author

@thaJeztah It passed now :-)

@thaJeztah thaJeztah removed the status/failing-ci Indicates that the PR in its current state fails the test suite label Jun 7, 2016
@WeiZhang555
Copy link
Copy Markdown
Contributor Author

@cpuguy83
Copy link
Copy Markdown
Member

cpuguy83 commented Jun 8, 2016

LGTM

@vdemeester
Copy link
Copy Markdown
Member

LGTM 🐮

@vdemeester vdemeester merged commit e884a51 into moby:master Jun 8, 2016
@WeiZhang555 WeiZhang555 deleted the cobra-stats branch June 9, 2016 02:24
@dnephin dnephin mentioned this pull request Jul 18, 2016
43 tasks
dnephin pushed a commit to dnephin/docker that referenced this pull request Apr 17, 2017
Migrate stats and events command to cobra
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants