Skip to content

Use spf13/cobra for docker version#23333

Merged
vdemeester merged 1 commit intomoby:masterfrom
yongtang:23211-spf13-cobra-version
Jun 7, 2016
Merged

Use spf13/cobra for docker version#23333
vdemeester merged 1 commit intomoby:masterfrom
yongtang:23211-spf13-cobra-version

Conversation

@yongtang
Copy link
Copy Markdown
Member

@yongtang yongtang commented Jun 7, 2016

This fix is part of the effort to convert commands to spf13/cobra #23211.

This fix coverted command docker version to use spf13/cobra

NOTE: Most of the commands like run, images etc. goes to packages of container, image, network, etc.

Didn't find a good place for docker version so just use the package client for now.

Signed-off-by: Yong Tang [email protected]

@yongtang yongtang mentioned this pull request Jun 7, 2016
Closed
43 tasks
@vdemeester vdemeester added this to the 1.12.0 milestone Jun 7, 2016
@vdemeester
Copy link
Copy Markdown
Member

vdemeester commented Jun 7, 2016 •
edited
Loading

Make sense I think 😇

LGTM 🐮

/cc @thaJeztah @dnephin

@vdemeester
Copy link
Copy Markdown
Member

vdemeester commented Jun 7, 2016 •
edited
Loading

@yongtang hum I think a system package (with info, events and version) would make more sense 👼
See #23334 (comment)

@yongtang yongtang force-pushed the 23211-spf13-cobra-version branch from f9c8df0 to e4ef152 Compare June 7, 2016 12:58
@yongtang
Copy link
Copy Markdown
Member Author

yongtang commented Jun 7, 2016

Thanks @vdemeester. The pull request has been updated to change the version under system package.

@thaJeztah
Copy link
Copy Markdown
Member

thaJeztah commented Jun 7, 2016

Failing test will be fixed by #23340

@yongtang
Use spf13/cobra for docker version
bc82e51 
This fix is part of the effort to convert commands to spf13/cobra moby#23211.

Thif fix coverted command `docker version` to use spf13/cobra

NOTE: Most of the commands like `run`, `images` etc. goes to packages of
`container`, `image`, `network`, etc. Didn't find a good place for
`docker version` so just use the package `client` for now.

Signed-off-by: Yong Tang <[email protected]>
@yongtang yongtang force-pushed the 23211-spf13-cobra-version branch from e4ef152 to bc82e51 Compare June 7, 2016 15:11
@dnephin
Copy link
Copy Markdown
Member

dnephin commented Jun 7, 2016

LGTM

@vdemeester
Copy link
Copy Markdown
Member

vdemeester commented Jun 7, 2016

LGTM 🐸

@thaJeztah
Copy link
Copy Markdown
Member

thaJeztah commented Jun 7, 2016 •
edited
Loading

hm, seccomp failure on experimental; flaky test? https://jenkins.dockerproject.org/job/Docker-PRs-experimental/19634/console

15:39:32 ----------------------------------------------------------------------
15:39:32 FAIL: docker_cli_run_unix_test.go:1040: DockerSuite.TestRunSeccompDefaultProfileAcct
15:39:32 
15:39:32 docker_cli_run_unix_test.go:1090:
15:39:32     c.Assert(err, checker.IsNil)
15:39:32 ... value *errors.errorString = &errors.errorString{s:"goroutine 0: expected Operation not permitted, got: /go/src/github.com/docker/docker/bundles/1.12.0-dev/test-integration-cli/../binary-client/docker: Error response from daemon: Error processing tar file(exit status 1): symlink libbz2.so.1.0.4 /lib/x86_64-linux-gnu/libbz2.so.1: no space left on device.\nSee '/go/src/github.com/docker/docker/bundles/1.12.0-dev/test-integration-cli/../binary-client/docker run --help'.\n"} ("goroutine 0: expected Operation not permitted, got: /go/src/github.com/docker/docker/bundles/1.12.0-dev/test-integration-cli/../binary-client/docker: Error response from daemon: Error processing tar file(exit status 1): symlink libbz2.so.1.0.4 /lib/x86_64-linux-gnu/libbz2.so.1: no space left on device.\nSee '/go/src/github.com/docker/docker/bundles/1.12.0-dev/test-integration-cli/../binary-client/docker run --help'.\n")
15:39:32 
15:40:00 
15:40:00 ----------------------------------------------------------------------
15:40:00 FAIL: docker_cli_run_unix_test.go:1094: DockerSuite.TestRunSeccompDefaultProfileNS
15:40:00 
15:40:00 docker_cli_run_unix_test.go:1153:
15:40:00     c.Assert(err, checker.IsNil)
15:40:00 ... value *errors.errorString = &errors.errorString{s:"goroutine 5: expected hello4, got: /go/src/github.com/docker/docker/bundles/1.12.0-dev/test-integration-cli/../binary-client/docker: Error response from daemon: Error processing tar file(exit status 1): symlink tic /usr/bin/captoinfo: no space left on device.\nSee '/go/src/github.com/docker/docker/bundles/1.12.0-dev/test-integration-cli/../binary-client/docker run --help'.\n, exit status 125: /go/src/github.com/docker/docker/bundles/1.12.0-dev/test-integration-cli/../binary-client/docker: Error response from daemon: Error processing tar file(exit status 1): symlink tic /usr/bin/captoinfo: no space left on device.\nSee '/go/src/github.com/docker/docker/bundles/1.12.0-dev/test-integration-cli/../binary-client/docker run --help'.\n"} ("goroutine 5: expected hello4, got: /go/src/github.com/docker/docker/bundles/1.12.0-dev/test-integration-cli/../binary-client/docker: Error response from daemon: Error processing tar file(exit status 1): symlink tic /usr/bin/captoinfo: no space left on device.\nSee '/go/src/github.com/docker/docker/bundles/1.12.0-dev/test-integration-cli/../binary-client/docker run --help'.\n, exit status 125: /go/src/github.com/docker/docker/bundles/1.12.0-dev/test-integration-cli/../binary-client/docker: Error response from daemon: Error processing tar file(exit status 1): symlink tic /usr/bin/captoinfo: no space left on device.\nSee '/go/src/github.com/docker/docker/bundles/1.12.0-dev/test-integration-cli/../binary-client/docker run --help'.\n")
15:40:00

@cpuguy83
Copy link
Copy Markdown
Member

cpuguy83 commented Jun 7, 2016

@thaJeztah "no space left on device"

@thaJeztah
Copy link
Copy Markdown
Member

thaJeztah commented Jun 7, 2016

oh! read over it, 😊 thanks

@vdemeester
Copy link
Copy Markdown
Member

vdemeester commented Jun 7, 2016

It's green (experimental too)

@vdemeester vdemeester merged commit 13d101d into moby:master Jun 7, 2016
@yongtang yongtang deleted the 23211-spf13-cobra-version branch June 8, 2016 02:04
dnephin pushed a commit to dnephin/docker that referenced this pull request Apr 17, 2017
@vdemeester
Merge pull request moby#23333 from yongtang/23211-spf13-cobra-version
92daed0 
Use spf13/cobra for docker version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area/cli Client status/4-merge

Projects

None yet

Milestone

1.12.0

Development

Successfully merging this pull request may close these issues.

6 participants

@yongtang @vdemeester @thaJeztah @dnephin @cpuguy83 @GordonTheTurtle