Skip to content

Migrate rm command to cobra#23311

Merged
cpuguy83 merged 1 commit intomoby:masterfrom
WeiZhang555:cobra-rm
Jun 7, 2016
Merged

Migrate rm command to cobra#23311
cpuguy83 merged 1 commit intomoby:masterfrom
WeiZhang555:cobra-rm

Conversation

@WeiZhang555
Copy link
Copy Markdown
Contributor

@WeiZhang555 WeiZhang555 commented Jun 6, 2016

part of #23211

Signed-off-by: Zhang Wei [email protected]

@dnephin dnephin mentioned this pull request Jun 6, 2016
Closed
43 tasks
@thaJeztah thaJeztah added this to the 1.12.0 milestone Jun 6, 2016
@thaJeztah thaJeztah added the area/cli Client label Jun 6, 2016
@LK4D4
Copy link
Copy Markdown
Contributor

LK4D4 commented Jun 6, 2016

@WeiZhang555 need rebase :(

@WeiZhang555
Copy link
Copy Markdown
Contributor Author

WeiZhang555 commented Jun 7, 2016

@LK4D4 Rebased 😎

@vdemeester
Copy link
Copy Markdown
Member

vdemeester commented Jun 7, 2016

LGTM 🐮
but needs a rebase 😝

@WeiZhang555
Copy link
Copy Markdown
Contributor Author

WeiZhang555 commented Jun 7, 2016

Rebased, again.

@cpuguy83
Copy link
Copy Markdown
Member

cpuguy83 commented Jun 7, 2016 

14:44:15 FAIL: docker_cli_rename_test.go:69: DockerSuite.TestRenameInvalidName
14:44:15 
14:44:15 docker_cli_rename_test.go:78:
14:44:15     c.Assert(out, checker.Contains, "\"docker rename\" requires exactly 2 argument(s).", check.Commentf("%v", err))
14:44:15 ... obtained string = "Error: Neither old nor new names may be empty\n"
14:44:15 ... substring string = "\"docker rename\" requires exactly 2 argument(s)."
14:44:15 ... exit status 1: Error: Neither old nor new names may be empty
14:44:15

@thaJeztah
Copy link
Copy Markdown
Member

thaJeztah commented Jun 7, 2016

The TestRenameInvalidName should be fixed now, so triggered a rebuild for gccgo and windowsTP5

@WeiZhang555
Copy link
Copy Markdown
Contributor Author

WeiZhang555 commented Jun 7, 2016

gccgo still fails, I guess it's not related to this.

@thaJeztah
Copy link
Copy Markdown
Member

thaJeztah commented Jun 7, 2016

darn; guess another job was running, but not visible here, and me triggering it cancelled that job 😢

@cpuguy83
Copy link
Copy Markdown
Member

cpuguy83 commented Jun 7, 2016

LGTM

@cpuguy83 cpuguy83 merged commit ce96ce9 into moby:master Jun 7, 2016
@WeiZhang555 WeiZhang555 deleted the cobra-rm branch June 7, 2016 23:27
dnephin pushed a commit to dnephin/docker that referenced this pull request Apr 17, 2017
@cpuguy83
Merge pull request moby#23311 from WeiZhang555/cobra-rm
51bd610 
Migrate rm command to cobra
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area/cli Client status/2-code-review

Projects

None yet

Milestone

1.12.0

Development

Successfully merging this pull request may close these issues.

6 participants

@WeiZhang555 @LK4D4 @vdemeester @cpuguy83 @thaJeztah @GordonTheTurtle