Migrate kill command to cobra#23297
Merged
thaJeztah merged 1 commit intomoby:masterfrom Jun 7, 2016
Merged
Conversation
vdemeester
added
area/cli
43 tasks
Member
|
oh! needs a rebase (sorry, lots of activity 😄) |
Contributor
Author
|
@thaJeztah Yep, it's true 😆 Rebased. |
Member
There was a problem hiding this comment.
Ah, I forgot this one when updating context use…
@WeiZhang555 could you update this to share the context ? something like
ctx := context.Background()
for _, name := range opts.containers {
if err := dockerCli.Client().ContainerKill(ctx, …) // …
}
Contributor
Author
There was a problem hiding this comment.
Oh, I see.
I'll do that.
Signed-off-by: Zhang Wei <[email protected]>
Contributor
Author
|
@vdemeester Updated as you suggested. |
Member
|
LGTM 🐰 |
Member
|
LGTM! |
dnephin
pushed a commit
to dnephin/docker
that referenced
this pull request
Apr 17, 2017
Migrate kill command to cobra
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #23211
Signed-off-by: Zhang Wei [email protected]