Use spf13/cobra for docker images#23292
Merged
thaJeztah merged 1 commit intomoby:masterfrom Jun 7, 2016
Merged
Conversation
43 tasks
vdemeester
added
area/cli
Member
|
LGTM 🐮 |
yongtang
force-pushed
the
23211-spf13-cobra-images
branch
2 times, most recently
from
8ca9e71 to
bbda620
Compare
Member
|
LGTM |
Contributor
|
@yongtang need rebase :/ |
yongtang
force-pushed
the
23211-spf13-cobra-images
branch
from
bbda620 to
5a6de27
Compare
Member
Author
|
Thanks @vdemeester @cpuguy83 @LK4D4 for the review. The PR has been rebased and updated. |
yongtang
force-pushed
the
23211-spf13-cobra-images
branch
from
5a6de27 to
ab07ed3
Compare
Member
|
test will be fixed by #23340 |
This fix is part of the effort to convert commands to spf13/cobra moby#23211. Thif fix coverted command `docker images` to use spf13/cobra NOTE: As part of this fix, a new function `RequiresMaxArgs()` has been defined in `cli/required.go`. This func returns an error if there is not at most max args Signed-off-by: Yong Tang <[email protected]>
yongtang
force-pushed
the
23211-spf13-cobra-images
branch
from
ab07ed3 to
65a0034
Compare
Member
|
Userns is green, but didn't notify GitHub; |
Member
|
LGTM |
dnephin
pushed a commit
to dnephin/docker
that referenced
this pull request
Apr 17, 2017
Use spf13/cobra for docker images
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix is part of the effort to convert commands to spf13/cobra #23211.
Thif fix coverted command
docker imagesto use spf13/cobraNOTE: As part of this fix, a new function
RequiresMaxArgs()has been defined in
cli/required.go. This func returns anerror if there is not at most max args
Signed-off-by: Yong Tang [email protected]