Use spf13/cobra for docker rename#23290
Merged
vdemeester merged 1 commit intomoby:masterfrom Jun 7, 2016
Merged
Conversation
43 tasks
vdemeester
added
area/cli
Member
|
LGTM 🐮 |
yongtang
force-pushed
the
23211-spf13-cobra-rename
branch
from
f0b88d1 to
9b9cea4
Compare
Member
Author
|
Thanks @vdemeester. The PR has been rebased. |
Member
|
Oh, fun, just stumbled on a bug; while testing this. Opening an issue #23319 |
Member
|
unfortunately needs another rebase (but that's kinda expected 😄) LGTM after a rebase! |
This fix is part of the effort to convert commands to spf13/cobra moby#23211. Thif fix coverted command `docker rename` to use spf13/cobra Signed-off-by: Yong Tang <[email protected]>
yongtang
force-pushed
the
23211-spf13-cobra-rename
branch
from
9b9cea4 to
70f7ccb
Compare
Member
Author
|
@thaJeztah No problem. Just rebased. Guess will need several round to get all merged. |
Member
|
Yes, it's probably all because the |
yongtang
added a commit
to yongtang/docker
that referenced
this pull request
Jun 7, 2016
At the time the pull request: Use spf13/cobra for docker rename moby#23290 was created, there was an issue in cobra so the test `DockerSuite.TestRenameInvalidName` was updated. Now the issue in cobra has been fixed in: Use spf13/cobra for docker import moby#23269 so the test related to `docker rename` (`DockerSuite.TestRenameInvalidName`) needs to be reverted back. This fix is related to spf13/cobra moby#23211. Signed-off-by: Yong Tang <[email protected]>
dnephin
pushed a commit
to dnephin/docker
that referenced
this pull request
Apr 17, 2017
Use spf13/cobra for docker rename
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix is part of the effort to convert commands to spf13/cobra #23211.
Thif fix coverted command
docker renameto use spf13/cobraSigned-off-by: Yong Tang [email protected]