Use spf13/cobra for docker port#23286
Merged
vdemeester merged 1 commit intomoby:masterfrom Jun 6, 2016
Merged
Conversation
43 tasks
Member
|
LGTM 🐮 |
This fix is part of the effort to convert commands to spf13/cobra moby#23211. Thif fix coverted command `docker port` to use spf13/cobra Note: As part of this fix, a new function `RequiresMinMaxArgs(min int, max int)` has been added in cli/required.go. This function restrict the args to be at least min and at most max. Signed-off-by: Yong Tang <[email protected]>
yongtang
force-pushed
the
23211-spf13-cobra-port
branch
from
dad784b to
d5971c2
Compare
Member
Author
|
Thanks @vdemeester the PR has been rebased. |
Member
|
LGTM, thanks @yongtang |
dnephin
pushed a commit
to dnephin/docker
that referenced
this pull request
Apr 17, 2017
Use spf13/cobra for docker port
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix is part of the effort to convert commands to spf13/cobra #23211.
Thif fix coverted command
docker portto use spf13/cobraNote: As part of this fix, a new function
RequiresMinMaxArgs(min int, max int)has been added in cli/required.go. This function restrict the args to be at least min and at most max.
Signed-off-by: Yong Tang [email protected]