Use spf13/cobra for docker unpause#23279
Merged
vdemeester merged 1 commit intomoby:masterfrom Jun 6, 2016
Merged
Conversation
Member
|
Need to remove the commented code |
yongtang
force-pushed
the
23211-spf13-cobra-unpause
branch
from
98513e4 to
4b2f495
Compare
Member
Author
|
@cpuguy83 Sorry my bad. Just updated the pull request. Thanks for pointing it out. |
Member
There was a problem hiding this comment.
think we can remove the [OPTIONS] at some point here (because we only have --help), but we can do that for all commands that don't take options in another PR
Member
|
LGTM |
yongtang
force-pushed
the
23211-spf13-cobra-unpause
branch
2 times, most recently
from
6c9eed1 to
24e605a
Compare
Member
Author
|
Thanks @cpuguy83 @vdemeester @thaJeztah for the review. The |
43 tasks
Member
|
re-LGTM |
This fix is part of the effort to convert commands to spf13/cobra moby#23211. Thif fix coverted command `docker unpause` to use spf13/cobra Signed-off-by: Yong Tang <[email protected]>
yongtang
force-pushed
the
23211-spf13-cobra-unpause
branch
from
24e605a to
8ea7733
Compare
Member
|
LGTM |
Member
|
LGTM 🐮 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix is part of the effort to convert commands to spf13/cobra #23211.
Thif fix coverted command
docker unpauseto use spf13/cobraSigned-off-by: Yong Tang [email protected]