Use spf13/cobra for docker stop#23276
Merged
vdemeester merged 1 commit intomoby:masterfrom Jun 5, 2016
Merged
Conversation
This fix is part of the effort to convert commands to spf13/cobra moby#23211. Thif fix coverted command `docker stop` to use spf13/cobra Signed-off-by: Yong Tang <[email protected]>
vdemeester
added
area/cli
43 tasks
Member
|
Looks like we may need to add some extra parsing if people use a single dash (but that's probably a "global" change, not for this PR); @vdemeester @dnephin wdyt? ^^ |
Member
|
(current error looks like this); |
Member
|
LGTM (unless we decide to make that change as part of this PR) |
Member
|
@thaJeztah yeah this can be changed after (and both error are not really good anyway 👼) |
dnephin
pushed a commit
to dnephin/docker
that referenced
this pull request
Apr 17, 2017
Use spf13/cobra for docker stop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix is part of the effort to convert commands to spf13/cobra #23211.
Thif fix coverted command
docker stopto use spf13/cobraSigned-off-by: Yong Tang [email protected]