Use spf13/cobra for docker login and docker logout#23265
Merged
LK4D4 merged 1 commit intomoby:masterfrom Jun 13, 2016
Merged
Conversation
vdemeester
force-pushed
the
migrate-login-logout-to-cobra
branch
3 times, most recently
from
e77f0b8 to
ad98900
Compare
43 tasks
Member
There was a problem hiding this comment.
The parameter should probably be max otherwise it's kind of confusing
Member
Author
There was a problem hiding this comment.
oh damn you're absolutely right 😓
/me was in robot mode I guess 😅
vdemeester
force-pushed
the
migrate-login-logout-to-cobra
branch
7 times, most recently
from
26f804b to
68294a4
Compare
Contributor
|
This already needs a rebase unfortunately @vdemeester |
vdemeester
force-pushed
the
migrate-login-logout-to-cobra
branch
from
68294a4 to
36624c9
Compare
Member
|
LGTM |
Member
|
LGTM ping @runcom PTAL as well |
Member
|
also, I think the commits should be squashed, because some changes are in the wrong commit |
vdemeester
force-pushed
the
migrate-login-logout-to-cobra
branch
2 times, most recently
from
0f27e87 to
94ef8fe
Compare
Member
|
LGTM but this needs a rebase :( |
vdemeester
force-pushed
the
migrate-login-logout-to-cobra
branch
from
94ef8fe to
50ba007
Compare
Also moves some common stuff around : - `api/client/registry.go` for registry related method (`ElectAuthServer`, …) - `api/client/credentials.go` to interact with credentials Migrate logout command to cobra Signed-off-by: Vincent Demeester <[email protected]>
vdemeester
force-pushed
the
migrate-login-logout-to-cobra
branch
from
50ba007 to
baf4677
Compare
Contributor
|
LGTM |
dnephin
pushed a commit
to dnephin/docker
that referenced
this pull request
Apr 17, 2017
…-cobra Use spf13/cobra for docker login and docker logout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves registry command login and logout to
api/client/registry/login.goandapi/client/registry/logout.goand use cobra 🐍.Also moved some utils method in better files.
/cc @dnephin @thaJeztah @LK4D4 @cpuguy83
🐸
Signed-off-by: Vincent Demeester [email protected]